Skip to content

buildGoModule: remove compatibility layer for directly specified CGO_ENABLED#441828

Merged
ShamrockLee merged 1 commit intoNixOS:masterfrom
ShamrockLee:build-go-module-nocompat-cgo-enabled
Sep 21, 2025
Merged

buildGoModule: remove compatibility layer for directly specified CGO_ENABLED#441828
ShamrockLee merged 1 commit intoNixOS:masterfrom
ShamrockLee:build-go-module-nocompat-cgo-enabled

Conversation

@ShamrockLee
Copy link
Contributor

@ShamrockLee ShamrockLee commented Sep 10, 2025 •
edited
Loading

Subsequent clean-up for PR #359641, removing the compatibility layer and simplify the expression.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@ShamrockLee ShamrockLee force-pushed the build-go-module-nocompat-cgo-enabled branch 2 times, most recently from 330d0ed to 5b98770 Compare September 10, 2025 17:23
@nixpkgs-ci nixpkgs-ci bot added 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 8.has: changelog This PR adds or changes release notes 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 8.has: documentation This PR adds or changes documentation and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Sep 10, 2025
@ShamrockLee ShamrockLee force-pushed the build-go-module-nocompat-cgo-enabled branch from 5b98770 to 3c9b0f8 Compare September 10, 2025 18:15
@ShamrockLee ShamrockLee marked this pull request as ready for review September 10, 2025 18:36
@ShamrockLee
Copy link
Contributor Author

ShamrockLee commented Sep 10, 2025

@ofborg build nixpkgs-manual
@ofborg build tests.nixos-functions.nixos-test

@ShamrockLee
Copy link
Contributor Author

ShamrockLee commented Sep 10, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 441828
Commit: 3c9b0f85a4e2cf540fdba870bc035d4145d30c06

x86_64-linux

⏩ 1 package blacklisted:
  • tests.nixos-functions.nixos-test
✅ 1 package built:
  • nixpkgs-manual

wolfgangwalther
wolfgangwalther reviewed Sep 21, 2025
View reviewed changes
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 21, 2025
@ShamrockLee ShamrockLee added this pull request to the merge queue Sep 21, 2025
Merged via the queue into NixOS:master with commit adf8d64 Sep 21, 2025
61 of 64 checks passed
@ShamrockLee ShamrockLee deleted the build-go-module-nocompat-cgo-enabled branch September 21, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@Mic92 Mic92 Awaiting requested review from Mic92

@katexochen katexochen Awaiting requested review from katexochen

@zowoq zowoq Awaiting requested review from zowoq

Assignees

No one assigned

Labels

6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShamrockLee @wolfgangwalther