Skip to content

haskellPackages.cabal2nix-unstable: 2025-06-14 -> 2025-09-06#441324

Merged
sternenseemann merged 1 commit intoNixOS:masterfrom
sternenseemann:cabal2nix-unstable-2025-09-06
Sep 9, 2025
Merged

haskellPackages.cabal2nix-unstable: 2025-06-14 -> 2025-09-06#441324
sternenseemann merged 1 commit intoNixOS:masterfrom
sternenseemann:cabal2nix-unstable-2025-09-06

Conversation

@sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Sep 8, 2025 •
edited
Loading

See also 1f230cd.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 6.topic: haskell General-purpose, statically typed, purely functional programming language labels Sep 8, 2025
@sternenseemann
Copy link
Member Author

sternenseemann commented Sep 8, 2025

Preparation for #441101.

@sternenseemann sternenseemann marked this pull request as ready for review September 8, 2025 22:57
@sternenseemann sternenseemann mentioned this pull request Sep 8, 2025
Closed
3 tasks
@sternenseemann sternenseemann force-pushed the cabal2nix-unstable-2025-09-06 branch from ec842b3 to 64162e2 Compare September 8, 2025 23:00
@sternenseemann sternenseemann mentioned this pull request Sep 8, 2025
Merged
emilazy
emilazy approved these changes Sep 9, 2025
View reviewed changes
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkgs/development/haskell-modules/hackage-packages.nix
text
yaml
];
doCheck = false;
Copy link
Member

@emilazy emilazy Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected?

Copy link
Contributor

@wolfgangwalther wolfgangwalther Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, changed here: NixOS/cabal2nix@5a04e6c

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 9, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Sep 9, 2025
@sternenseemann sternenseemann merged commit ca3da94 into NixOS:master Sep 9, 2025
31 of 33 checks passed
@sternenseemann sternenseemann deleted the cabal2nix-unstable-2025-09-06 branch September 9, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther approved these changes

@emilazy emilazy emilazy approved these changes

@maralorn maralorn Awaiting requested review from maralorn

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sternenseemann @wolfgangwalther @emilazy