Skip to content

verible: fix darwin hash#441058

Closed
GaetanLepage wants to merge 3 commits intoNixOS:masterfrom
GaetanLepage:verible
Closed

verible: fix darwin hash#441058
GaetanLepage wants to merge 3 commits intoNixOS:masterfrom
GaetanLepage:verible

Conversation

@GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Sep 7, 2025

Things done

cc @hzeller @newAM

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Sep 7, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Sep 7, 2025
@nix-owners nix-owners bot requested review from hzeller and newAM September 7, 2025 22:18
@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 441058
Commit: 046ce3061e112750bc41aaf793df46be78ec30e4


aarch64-darwin

❌ 1 package failed to build:
  • verible

@GaetanLepage
Copy link
Contributor Author

the bazel-7-6-0 dependency derivation fails to build with:

ERROR: no such package '@@bazel_tools~xcode_configure_extension~local_config_xcode//': BUILD file not found in directory '' of external repository @@bazel_tools~xcode_configure_extension~local_config_xcode. Add a BUILD file to a directory to mark it as a package.
ERROR: /private/tmp/nix-build-bazel-7.6.0.drv-0/bazel_TrE9NQum/out/external/bazel_tools/tools/cpp/BUILD:125:6: no such package '@@bazel_tools~xcode_configure_extension~local_config_xcode//': BUILD file not found in directory '' of external repository @@bazel_tools~xcode_configure_extension~local_config_xcode. Add a BUILD file to a directory to mark it as a package. and referenced by '@@bazel_tools//tools/cpp:host_xcodes'
ERROR: Analysis of target '//src:bazel_nojdk' failed; build aborted: Analysis failed
INFO: Elapsed time: 14.127s, Critical Path: 0.02s
INFO: 1 process: 1 internal.
ERROR: Build did NOT complete successfully
FAILED:

ERROR: Could not build Bazel

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Sep 7, 2025
@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 441058
Commit: 8b3c7ecd50064e6ea939e89a14525eb20175f87c

@GaetanLepage GaetanLepage requested a review from NickCao September 7, 2025 22:35
GaetanLepage added a commit to nix-community/nixvim that referenced this pull request Sep 7, 2025
aarch64-linux = "sha256-jgh+wEqZba30MODmgmPoQn1ErNmm40d16jB/kE2jYPg=";
x86_64-linux = "sha256-kiI/LX0l9ERxItsqiAyl+BP3QnLr0Ly2YVb988M4jVs=";
aarch64-darwin = "sha256-bkw4ErWYblzr3lQhoXSBqIBHjXzhZHeTKdT0E/YsiFQ=";
aarch64-darwin = "sha256-Ivx6KCzAxy6DAffVirb90ZMSGTIS/UXQEhZQebFjV3s=";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error: hash mismatch in fixed-output derivation '/nix/store/9nkz0g7xcppsz1dfdhn4s2z35z9qz671-verible-0.0.3956-deps.tar.gz.drv':
           likely URL: (unknown)
            specified: sha256-Ivx6KCzAxy6DAffVirb90ZMSGTIS/UXQEhZQebFjV3s=
                  got: sha256-bkw4ErWYblzr3lQhoXSBqIBHjXzhZHeTKdT0E/YsiFQ=
        expected path: /nix/store/d30pzvj08p7hlhsb3q4fczhp790cmyn7-verible-0.0.3956-deps.tar.gz
             got path: /nix/store/0d8mncfgdyppca3vgchwkg0qj30lfx2i-verible-0.0.3956-deps.tar.gz

This is most likely a case-sensitivity issue – please don’t break the hash for users with case‐sensitive stores. It should be normalized in postFetch instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, good to know. How exactly should this be done? Is there any related section in the manual?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a matter of figuring out what files are colliding in case/normalization, figuring out if that’s load‐bearing, and then adjusting postFetch to create a result without such collisions. Then the hash is the same regardless.

github-merge-queue bot pushed a commit to nix-community/nixvim that referenced this pull request Sep 8, 2025
@GaetanLepage
Copy link
Contributor Author

Closing in favor of #445793.

@GaetanLepage GaetanLepage deleted the verible branch September 26, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants