tesseract: fix passthru override

[PatrickDaG]

fixes tesseract passthru.
error was surfaced by: #423615
fixes: #440907

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[winterqt]

Could you see if just removing loPrio from the callPackage for tesseract4 and 5 fixes this? (This should only be broken atm for those two, 3 should be fine.)

[PatrickDaG]

Yeah that also seems to fix it. That’s probably the reason why the #423615 started breaking it. I still think this is the better fix. It would've been broken anyway if anyone tried using overrideAttrs on this package.

[eclairevoyant]

nit: // is right associative and extremely low precedence... so these are redundant. At least for the multiline ones, removing them might make the nesting shallower and improve readability.

https://nix.dev/manual/nix/2.28/language/operators

[PatrickDaG]

I've remove some of the brackets. The others I kinda think are good to have as I don't think everyone knows the precedence by heart and this just makes it clear to see what's going on.

[philiptaron]

I think this looks ugly as sin and falls afoul of the recently merged advice to not make use of overrideAttrs in Nixpkgs.

That said, it does indeed fix the passthru override. I'll whip up a short PR to make this look a little better.

[eclairevoyant]

falls afoul of the recently merged advice to not make use of overrideAttrs in Nixpkgs.

Wasn't that more of a security concern? I don't see this as creating a new version of the package if it's merely setting passthru. Though undoubtedly it'd be nice to avoid it if possible.

[eclairevoyant]

Any remaining blockers?