perfect_dark: un-vendor gzip; refactor derivation builder; add updateScript#440718
perfect_dark: un-vendor gzip; refactor derivation builder; add updateScript#440718SigmaSquadron merged 3 commits intomasterfrom unknown repository
Conversation
- Use sdl2-compat attribute instead of SDL2 - Remove `hardeningEnable` attribute - Limit `patchShebangs` to `tools/assetmgr`
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
|
|
||
| preConfigure = '' | ||
| patchShebangs --build . | ||
| patchShebangs --build tools/assetmgr |
There was a problem hiding this comment.
why specify this path? doesn't this makes the process less robust to future changes?
There was a problem hiding this comment.
We generally should only patch files which need to be patched. I'd rather the build fail because of an unpatched file that we can review and add than have a new patched file execute without us knowing when updating.
There was a problem hiding this comment.
But I can drop this change if it's really not worth it, we can see what @SigmaSquadron says.
There was a problem hiding this comment.
I think in this particular case, it's safe to assume that any script is either part of the build process (and will need the patching) or will not be used at runtime (because we install only one binary in /bin/).
In any case, it's not important.
There was a problem hiding this comment.
I agree with @normalcea here. It's best if we have absolute control over which files in the source are executable.
ghost
deleted the
2 participants
As a follow-up to #306767, this PR improves upon the derivation further:
lib.licenses.gpl3Plusattribute frommeta.licensespassthru.updateScriptthat works with the modified fetcher.No obvious regressions detected when running or building perfect dark.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.