Fix freeform usages in some modules#440462
Merged
Lassulus merged 4 commits intoNixOS:masterfrom Sep 15, 2025
Merged
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
11 tasks
hsjobeki
force-pushed
the
fix-freeform-usage
branch
from
2f55fd5 to
30b6477
Compare
nixpkgs-ci
bot
added
the
12.approvals: 1
Member
|
@hsjobeki told me that it should be correct (in theory) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bunch of modules.
freeformType needs to be an
attrsOftype. Otherwise its behavior is bugged, and can lead to weird bugs, depending on the used type.There are still many more modules that use
freeformTypewrongly. I would appreciate help on migrating them.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.