Skip to content

Comments

Revert "maintainers: require GitHub handle (documentation) (#437469)"#439389

Closed
zeuner wants to merge 1 commit intoNixOS:masterfrom
zeuner:revert-maintainer
Closed

Revert "maintainers: require GitHub handle (documentation) (#437469)"#439389
zeuner wants to merge 1 commit intoNixOS:masterfrom
zeuner:revert-maintainer

Conversation

@zeuner
Copy link
Contributor

@zeuner zeuner commented Sep 2, 2025

This PR reverts "maintainers: require GitHub handle (documentation) (#437469)" (commit d3b00da.

The PR has been merged within maybe a day. Due to its severe impact, this wasn't supposed to happen without more in-depth evaluation and preparation:

What the author tries to do here has to a great extent already been subject to an RFC (NixOS/rfcs#167), but it ended up not being merged. Obviously, it could not reach a community consensus back then. If the author thinks this will work out differently as of today, he should go through the RFC process to make sure the intended change is in the best interest of the community. Considering that we're talking about a community reshape here (it would currently modify who can do meaningful contributions and who can't), a quickly merged PR does hardly correspond to its impact. Furthermore, it is designed to specifically affect community members which are not reachable through GitHub, so it might need even more time for proper community feedback.

Furthermore, the PR would make changes to the handling of personal data within nixpkgs. Specifically, personal data which could previously be provided based on deliberate consent would become mandatory. Due to regulations of personal data usage in different jurisdictions, we should make sure to avoid legal implications before attempting something like this. The PR does not state how it's supposed to achieve this, so it would be preferable to contact the maintainers who provided data based on the old data handling, and ask them whether they consent to the intended change.

The PR should be reverted for now, with the option to re-apply it after going through the RFC process, and acquiring the consent of the affected maintainers.

@NixOS/steering

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: policy discussion Discuss policies to work in and around Nixpkgs labels Sep 2, 2025
@nix-owners nix-owners bot requested a review from infinisil September 2, 2025 01:01
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Sep 2, 2025
Copy link
Contributor

@SigmaSquadron SigmaSquadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not reverting something that has achieved a positive consensus among several committers and is a net positive for the majority of Nixpkgs contributors. A GitHub account is currently required to have a maintainer entry in Nixpkgs.

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Sep 2, 2025
@infinisil
Copy link
Member

Thanks @SigmaSquadron, would've done the same

#437085 (comment)

@roberth
Copy link
Member

roberth commented Sep 2, 2025

I would support a parallel non-GitHub contributing workflow if we find a great enough number of passionate people who care most about that.

It'd be a significant effort that should detract minimally from other ongoing efforts, but it can be done with a sufficient number of hands.

Everyone will be happy to lift the current restriction as soon as a good parallel contributor workflow is enabled.

Let me know if you're interested in volunteering for such an effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: policy discussion Discuss policies to work in and around Nixpkgs 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants