Revert "maintainers: require GitHub handle (documentation) (#437469)"#439389
Closed
zeuner wants to merge 1 commit intoNixOS:masterfrom
Closed
Revert "maintainers: require GitHub handle (documentation) (#437469)"#439389zeuner wants to merge 1 commit intoNixOS:masterfrom
zeuner wants to merge 1 commit intoNixOS:masterfrom
Conversation
SigmaSquadron
requested changes
Sep 2, 2025
2 tasks
Member
|
Thanks @SigmaSquadron, would've done the same |
Member
|
I would support a parallel non-GitHub contributing workflow if we find a great enough number of passionate people who care most about that. It'd be a significant effort that should detract minimally from other ongoing efforts, but it can be done with a sufficient number of hands. Everyone will be happy to lift the current restriction as soon as a good parallel contributor workflow is enabled. Let me know if you're interested in volunteering for such an effort. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts "maintainers: require GitHub handle (documentation) (#437469)" (commit d3b00da.
The PR has been merged within maybe a day. Due to its severe impact, this wasn't supposed to happen without more in-depth evaluation and preparation:
What the author tries to do here has to a great extent already been subject to an RFC (NixOS/rfcs#167), but it ended up not being merged. Obviously, it could not reach a community consensus back then. If the author thinks this will work out differently as of today, he should go through the RFC process to make sure the intended change is in the best interest of the community. Considering that we're talking about a community reshape here (it would currently modify who can do meaningful contributions and who can't), a quickly merged PR does hardly correspond to its impact. Furthermore, it is designed to specifically affect community members which are not reachable through GitHub, so it might need even more time for proper community feedback.
Furthermore, the PR would make changes to the handling of personal data within
nixpkgs. Specifically, personal data which could previously be provided based on deliberate consent would become mandatory. Due to regulations of personal data usage in different jurisdictions, we should make sure to avoid legal implications before attempting something like this. The PR does not state how it's supposed to achieve this, so it would be preferable to contact the maintainers who provided data based on the old data handling, and ask them whether they consent to the intended change.The PR should be reverted for now, with the option to re-apply it after going through the RFC process, and acquiring the consent of the affected maintainers.
@NixOS/steering
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.