top-level/release-outpaths: move to ci/eval & refactor#439221
Merged
wolfgangwalther merged 7 commits intoNixOS:masterfrom Sep 3, 2025
Merged
top-level/release-outpaths: move to ci/eval & refactor#439221wolfgangwalther merged 7 commits intoNixOS:masterfrom
wolfgangwalther merged 7 commits intoNixOS:masterfrom
Conversation
These files are tightly coupled with the code in ci/eval and not used anywhere else. They are subject to the same backporting requirements as the remaining CI code. They are better placed next here.
By now, these files have been changed enough to not need the "vendored from" notes anymore. These links would still be there when going through the history of the file, but today GHA CI has not many similarities anymore to what ofborg did, so these are not really helpful.
This condition doesn't make a difference anymore, ever since we removed the tryEval code from this file and had already enabled unfree packages earlier anyway.
The following changes were made: - Using `lib.` instead of `builtins.` - Using `mapAttrsToList` instead of `mapAttrs` + `attrValues` - Joining two of the if conditions with the same return value - Using `traceIf` instead of `if` / `else` - Using `showAttrPath` instead of `concatStringsSep`
This should always be set anyways.
This attribute was supposed to be set on derivations, to make the release tools recurse into them. The remaining uses were all on regular attrsets, though, so this is safe to remove.
`pkgsArocc` and `pkgsZig` had been added to `release.nix`, so should be listed here as well.
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
nix-owners
bot
requested review from
K900,
Ma27,
MattSturgeon,
Mic92,
NeQuissimus,
TredwellGit,
alyssais,
natsukium,
philiptaron and
zowoq
philiptaron
approved these changes
Sep 1, 2025
nixpkgs-ci
bot
added
the
12.approvals: 1
2 tasks
Contributor
|
Anything else needed before this is merged? |
Contributor
Author
|
No, not really. Since there is nothing blocked on it, so far, I thought I'd keep it open a bit more just in case somebody wanted to chime in on anything. As soon as #439255 (comment) is figured out, I'd merge this, though, to get the other PR going. |
Contributor
|
I'd like to merge it then because I want to base things on it too 😁 |
Contributor
Author
|
Oh, of course, that's fine. |
Contributor
|
Successfully created backport PR for |
1 task
github-actions
bot
added
the
8.has: port to stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These files are tightly coupled with the code in ci/eval and not used anywhere else. They are subject to the same backporting requirements as the remaining CI code. They are better placed next here.
Followed up by some refactoring and cleanup while I was trying to understand the code in these files to the dot.
Best reviewed commit-by-commit.
Things done
Add a 👍 reaction to pull requests you find important.