Skip to content

some: put NIX_CFLAGS_COMPILE under env to fix withCFlags#439203

Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
SuperSandro2000:fix-some-NIX_CFLAGS_COMPILE
Sep 14, 2025
Merged

some: put NIX_CFLAGS_COMPILE under env to fix withCFlags#439203
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
SuperSandro2000:fix-some-NIX_CFLAGS_COMPILE

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Sep 1, 2025

see #438709

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Sep 1, 2025
Open
13 tasks
@SuperSandro2000 SuperSandro2000 force-pushed the fix-some-NIX_CFLAGS_COMPILE branch 2 times, most recently from 7751f57 to 4556c82 Compare September 1, 2025 14:11
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: python Python is a high-level, general-purpose programming language. labels Sep 1, 2025
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Sep 1, 2025
wolfgangwalther
wolfgangwalther approved these changes Sep 1, 2025
View reviewed changes
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 1, 2025
@SuperSandro2000 SuperSandro2000 force-pushed the fix-some-NIX_CFLAGS_COMPILE branch from 4556c82 to 4ac45c1 Compare September 14, 2025 17:39
@SuperSandro2000 SuperSandro2000 force-pushed the fix-some-NIX_CFLAGS_COMPILE branch from 4ac45c1 to f5347e9 Compare September 14, 2025 17:41
@ofborg ofborg bot removed the ofborg-internal-error Ofborg encountered an error label Sep 14, 2025
@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Sep 14, 2025
Merged via the queue into NixOS:master with commit 19a8f12 Sep 14, 2025
27 of 31 checks passed
@SuperSandro2000 SuperSandro2000 deleted the fix-some-NIX_CFLAGS_COMPILE branch September 14, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther approved these changes

@natsukium natsukium Awaiting requested review from natsukium

@mweinelt mweinelt Awaiting requested review from mweinelt

@andersk andersk Awaiting requested review from andersk

@FliegendeWurst FliegendeWurst Awaiting requested review from FliegendeWurst

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SuperSandro2000 @wolfgangwalther