aggregateModules: auto-extract modules output from kernel derivations#439178
Closed
Mic92 wants to merge 1 commit intoNixOS:masterfrom
Closed
aggregateModules: auto-extract modules output from kernel derivations#439178Mic92 wants to merge 1 commit intoNixOS:masterfrom
Mic92 wants to merge 1 commit intoNixOS:masterfrom
Conversation
Since NixOS#423933 nixpkgs kernel have a seperate "modules" output for kernel. This check now acts similar to lib.getBin/lib.getLib etc.
Mic92
force-pushed
the
aggregate-modules
branch
from
e94240f to
d21714d
Compare
13 tasks
Mic92
added a commit
to nix-community/disko
that referenced
this pull request
Sep 1, 2025
This is a hotfix that could be reverted if we get: NixOS/nixpkgs#439178 in.
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
Mic92
added a commit
to nix-community/disko
that referenced
this pull request
Sep 1, 2025
This is a hotfix that could be reverted if we get: NixOS/nixpkgs#439178 in.
Member
Author
|
Just using modules doesn't seem to be enough in our use case. Both outputs are required. |
Mic92
added a commit
to nix-community/disko
that referenced
this pull request
Sep 1, 2025
This is a hotfix that could be reverted if we get: NixOS/nixpkgs#439178 in.
Mic92
added a commit
to nix-community/disko
that referenced
this pull request
Sep 1, 2025
This is a hotfix that could be reverted if we get: NixOS/nixpkgs#439178 in.
github-merge-queue bot
pushed a commit
to nix-community/disko
that referenced
this pull request
Sep 1, 2025
This is a hotfix that could be reverted if we get: NixOS/nixpkgs#439178 in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #423933
nixpkgs kernel have a seperate "modules" output for kernel.
This check now acts similar to lib.getBin/lib.getLib etc.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.