[Backport release-25.05] ci/eval/compare: ping maintainers of removed packages#439133
Merged
wolfgangwalther merged 4 commits intorelease-25.05from Sep 1, 2025
Merged
Conversation
This change pings maintainers of actually removed packages, aka where the package's expression is deleted. This will not ping maintainers of packages that become invisible, because a (transitive) dependency of them is marked as insecure or broken. (cherry picked from commit 540e188)
This should not be necessary anymore, because packages that fail to evaluate should already be filtered out by the attrpath generation step in main eval. (cherry picked from commit 0753aa4)
It makes no sense to check newly added attrpaths for maintainers on the target branch - by definition these attrpaths won't exist, yet. We can avoid falling back to `null` for these etc. (cherry picked from commit e88dd3a)
Simplification after the last step. (cherry picked from commit 4126ef7)
2 tasks
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
nix-owners
bot
requested review from
MattSturgeon,
Mic92,
philiptaron,
wolfgangwalther and
zowoq
nixpkgs-ci
bot
added
the
9.needs: reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
release-25.05, triggered by a label in #438652.