gg-jj: patch lockfile to fix mismatched NPM/Cargo versions of Tauri - #439100
Merged
Conversation
nixpkgs-ci
Bot
added
10.rebuild-linux: 1-10
magneticflux-
force-pushed
the
push-rounlxnzyknq
branch
from
September 1, 2025 07:59
fa17e13 to
6be558f
Compare
alyssais
reviewed
Sep 1, 2025
Member
There was a problem hiding this comment.
Can you link to your upstream patch submission?
Contributor
Author
There was a problem hiding this comment.
Whoops, sorry about that! It's gulbanana/gg#68, I removed the loose patch file in this one.
magneticflux-
force-pushed
the
push-rounlxnzyknq
branch
3 times, most recently
from
September 2, 2025 00:23
3c24639 to
880fe2a
Compare
alyssais
requested changes
Sep 2, 2025
After NixOS#438726 updated `tauri` to >=2.8.0, it now checks for mismatched versions (tauri-apps/tauri#13993). This was always a problem, it just wasn't checked until now. This patch bumps the NPM versions to match the newer Cargo versions.
magneticflux-
force-pushed
the
push-rounlxnzyknq
branch
from
September 2, 2025 09:29
880fe2a to
6de5f37
Compare
alyssais
approved these changes
Sep 6, 2025
3 tasks
9 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #438726 updated
taurito >=2.8.0, it now checks for mismatched versions (tauri-apps/tauri#13993) and now fails to buildgg-jj. This was always a problem, it just wasn't checked until now. This patch bumps the NPM versions to match the newer Cargo versions (since I assume that's preferable to a downgrade).I struggled a bit to figure out how to properly apply the patch until I read the source of
fetchNpmDepssince it only documents thesrcandhashparameters. Passing@argsthrough to the actual derivation is obvious in hindsight 😆This will probably be resolved whenever
gg-jjgets some new activity since the new CLI will fail their build too. They don't have Issues enabled, but I'll send this patch upstream by itself as a surgical fix.Maintainer: @pluiedev
Last major change: @alyssais
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.