vimPlugins: fix meta shadowing

[khaneliman]

Currently shadows entire meta from generated.nix.

Discovered in nix-community/nixvim#3648

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[khaneliman]

Some of those are using buildVimPlugin, I have another Pr i'm creating for moving those to non-generated. I'll try and clean up the others that are redefining meta in overrides I'll draft #438708 real quick and switch back to finishing the meta task.

[khaneliman]

Alright, think I got em all.

[khaneliman]

Oops, yeah. I was just searching for meta = last round of changes.

[khaneliman]

third times the charm? Did a grug-far in that file for meta usage and it looks like they are all being merged with old.meta now (other than the buildVimPlugin usages.

[MattSturgeon]

SGTM, thanks!

Q: can we trust eval when it comes to vimPlugins or does the hydraPlatforms = [] mess with it?
It would be a shame to accidentally merge an eval failure if one of those old.metas doesn't actually exist...

EDIT: I guess seeing as hydraPlatforms is part of meta, CI must be able to evaluate meta in order to know there are no hydra platforms... Logically, we must be ok.

[khaneliman]

Yeah, I was worried about that too, at first. But our new plugin additions from generated.nix will always have a meta of some kind, specifically because of that hydraPlatforms meta.

[MattSturgeon]

Thanks! 🎉