Skip to content

vscode-extensions.ms-vscode.theme-tomorrowkit: drop#438448

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
qzylinra:ms-vscode.theme-tomorrowkit
Sep 4, 2025
Merged

vscode-extensions.ms-vscode.theme-tomorrowkit: drop#438448
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
qzylinra:ms-vscode.theme-tomorrowkit

Conversation

@qzylinra
Copy link
Contributor

@qzylinra qzylinra commented Aug 30, 2025

It hasn’t been updated for many years, and it still has an incorrect VS Code version constraint of 0.10.x.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@qzylinra
vscode-extensions.ms-vscode.theme-tomorrowkit: drop
9ee239d 
It hasn’t been updated for many years, and it still has an incorrect VS Code version constraint of 0.10.x.
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 30, 2025
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Sep 1, 2025
@nix-owners nix-owners bot requested a review from ratsclub September 1, 2025 10:27
@wolfgangwalther wolfgangwalther mentioned this pull request Sep 1, 2025
Merged
2 tasks
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Sep 1, 2025
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 1, 2025
@SuperSandro2000 SuperSandro2000 merged commit 40712bd into NixOS:master Sep 4, 2025
61 of 62 checks passed
@qzylinra qzylinra deleted the ms-vscode.theme-tomorrowkit branch September 4, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ratsclub ratsclub Awaiting requested review from ratsclub

1 more reviewer

@xiaoxiangmoe xiaoxiangmoe xiaoxiangmoe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: vscode A free and versatile code editor that supports almost every major programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. ofborg-internal-error Ofborg encountered an error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qzylinra @xiaoxiangmoe @SuperSandro2000 @wolfgangwalther