ci/eval: allow local comparison with rebuilds#437934
ci/eval: allow local comparison with rebuilds#437934philiptaron merged 2 commits intoNixOS:masterfrom
Conversation
|
Ah, mh, something is not working properly, yet. the |
|
Ah, it's that readlink stuff again. So currently, you'd need to do this: on the second step. Maybe we should fix this once and for all - but I have no idea where the |
23fdda6 to
ff5d2d4
Compare
|
The problem is that, When using I don't think we can properly solve this here :/ However, I changed the README slightly. It now has these two commands: This works because it doesn't use another symlink. |
That's precisely the fix I was going to suggest. Thanks Wolfgang. |
philiptaron
left a comment
There was a problem hiding this comment.
Approved with some comments and gripes.
ci/eval/default.nix
Outdated
There was a problem hiding this comment.
There are some non-README.md docs in this ci/eval/compare/default.nix file that are also relevant.
We had set a default of 5000 for local evaluation earlier for `singleSystem`, it makes sense to also use that for `full`. The README is also a bit outdated, because Nix 2.30 significantly changed the memory requirements. Rewriting the README to also show the ability to directly evaluate the current system only.
This allows running a full comparison between two commits locally. What was previously `eval.full` is now called `eval.all`. The new `eval.full` takes a `baseline` argument for the comparison.
ff5d2d4 to
ccc12c8
Compare
|
Successfully created backport PR for |
This allows running a full comparison between two commits locally.
What was previously
eval.fullis now calledeval.all. The neweval.fulltakes abaselineargument for the comparison.Fixes #437697 (comment)
@philiptaron could you give this a test-run? I only did some basic testing with "baseline == HEAD", but I think this should work with your example as well.
Things done
Add a 👍 reaction to pull requests you find important.