Skip to content

ci/eval: add a shebang to the stats comparison script #437697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
philiptaron wants to merge 1 commit into from
Closed

ci/eval: add a shebang to the stats comparison script #437697

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ci/eval/compare/cmp-stats.py
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
#! /usr/bin/env nix-shell
#! nix-shell -i "python3 -I" -p "python3.withPackages(ps: with ps; [ numpy pandas scipy ])"
Copy link
Contributor Author

@philiptaron philiptaron Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the production caller.

nixpkgs/ci/eval/compare/default.nix

Lines 128 to 134 in 0e40a79

(python3.withPackages (
ps: with ps; [
numpy
pandas
scipy
]
))

Copy link
Member

@Mic92 Mic92 Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could refer to current nixpkgs checkout here instead of relying on NIX_PATH, i.e. -I nixpkgs ../.. (don't remember the exact syntax in this case).

Copy link
Contributor Author

@philiptaron philiptaron Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's the expression that Silvan suggested in #425551:

#!/usr/bin/env nix-shell
#!nix-shell -i "python3 -I" --expr 'with import ../.. {}; with pkgs; mkShellNoCC { packages = [ python3.withPackages(ps: with ps; [ numpy pandas scipy ]) ] }'

Likely can be golfed substantially.


import json
import os
from scipy.stats import ttest_rel
Expand Down
Loading