maintainers.tomkoid: add github#437480
Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom Sep 2, 2025
Merged
Conversation
2 tasks
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
nixpkgs-ci
bot
removed
the
9.needs: reviewer
Contributor
Author
|
Got a response in #261671 (comment), which reads:
Will drop the drop and keep the reapply. |
wolfgangwalther
force-pushed
the
maintainers-tomkoid
branch
from
8d1e2cf to
03e63ed
Compare
wolfgangwalther
changed the title
Contributor
|
Successfully created backport PR for |
1 task
github-actions
bot
added
the
8.has: port to stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once #437469 is merged,
github/githubIdwill be required for maintainer entries.tomkoidcurrently doesn't have one and we can fix it in two ways: Either add the github data or drop the maintainer. This PR implements both changes, please look at the individual commits, not the overall diff. I intend to drop either the first commit or the last commit before merge.@tomkoid the decision is yours. Without feedback for 7 days, we'd drop your maintainer handle, because we shouldn't be adding data to it without your consent. Of course, even if that's the case, you can always be added again (with complete data ofc). So even if you'd miss this notification and only find out about it later, no problem.
Related: #261671 (comment)
Things done
Add a 👍 reaction to pull requests you find important.