Skip to content

crush: 0.6.1 -> 0.7.4#435690

Closed
bendlas wants to merge 4 commits intoNixOS:masterfrom
bendlas:update-crush
Closed

crush: 0.6.1 -> 0.7.4#435690
bendlas wants to merge 4 commits intoNixOS:masterfrom
bendlas:update-crush

Conversation

@bendlas
Copy link
Contributor

@bendlas bendlas commented Aug 21, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@bendlas bendlas requested a review from x123 August 21, 2025 22:10
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 21, 2025
@MisileLab MisileLab mentioned this pull request Aug 22, 2025
13 tasks
@MisileLab
Copy link
Contributor

@bendlas bendlas changed the title crush: 0.6.1 -> 0.7.0 crush: 0.6.1 -> 0.7.1 Aug 23, 2025
@bendlas
Copy link
Contributor Author

bendlas commented Aug 23, 2025

Oh, sorry, hadn't seen that you also had PR on. Updated to 0.7.1

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 23, 2025
@bendlas
Copy link
Contributor Author

bendlas commented Aug 23, 2025

Kind of surpised on why we're getting a merge conflict here. Seems we caught a random stray from a revert.

Looking through 106b141 I really don't understand why crush should have been affected. I don't think it ever went through staging, nor does it use python. Also, the associated PR seems for something else entirely. The revert looks like many other unrelated packages could have been affected.

Few questions for @mweinelt:
Are you sure that the revert was scoped correctly?
Are there further irregularities incoming, or can/should we rebase and move on?
Is there any associated discussion/review/explaination, that could have been linked to the revert?
Is somebody making sure that we didn't downgrade many other unrelated packages?

@bendlas bendlas closed this Aug 23, 2025
@bendlas bendlas reopened this Aug 23, 2025
@mweinelt
Copy link
Member

mweinelt commented Aug 23, 2025

Context is here: #432489 (comment)

Workflow: Inspected both parents of the merge and returned to the one that was staging-next, and not master. Then redid the merge without mergiraf.

@bendlas
Copy link
Contributor Author

bendlas commented Aug 23, 2025

Workflow: Inspected both parents of the merge and returned to the one that was staging-next, and not master. Then redid the merge without mergiraf.

If the merge was re-done correctly, shouldn't then crush have stayed at 0.6.1? I don't even see the correct version in staging-next, so it looks like it just got lost.

Is somebody checking all the other affected packages?

@bendlas
Copy link
Contributor Author

bendlas commented Aug 23, 2025

merge conflict has now been resolved

@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 23, 2025
@MisileLab
Copy link
Contributor

@bendlas bendlas changed the title crush: 0.6.1 -> 0.7.1 crush: 0.6.1 -> 0.7.2 Aug 29, 2025
@phanirithvij
Copy link
Member

0.7.4 is the latest version

@bendlas bendlas changed the title crush: 0.6.1 -> 0.7.2 crush: 0.6.1 -> 0.7.4 Aug 31, 2025
@MisileLab
Copy link
Contributor

@MisileLab
Copy link
Contributor

@bendlas
Copy link
Contributor Author

bendlas commented Sep 8, 2025

I won't be updating this PR any longer, because I'm no longer interested in crush, after I learned that it's a commercial re-licensing of https://github.com/sst/opencode

Feel free to take any commit from this, if you decide to open another PR

@bendlas bendlas closed this Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants