rustPlatform.buildRustPackage: fix cargoDeps inherited attribute overriding#435239
Open
ShamrockLee wants to merge 1 commit intoNixOS:masterfrom
Open
rustPlatform.buildRustPackage: fix cargoDeps inherited attribute overriding#435239ShamrockLee wants to merge 1 commit intoNixOS:masterfrom
ShamrockLee wants to merge 1 commit intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/is-it-possible-to-override-cargosha256-in-buildrustpackage/4393/28 |
ShamrockLee
changed the title
Contributor
Author
|
@ofborg build lixStatic |
Contributor
Author
|
Contributor
Author
|
|
Contributor
Author
|
|
nixpkgs-ci
bot
added
9.needs: reviewer
13 tasks
axelkar
approved these changes
Oct 14, 2025
Member
axelkar
left a comment
axelkar
left a comment
There was a problem hiding this comment.
Code looks good, I haven't tested it though.
| RUSTFLAGS = "-C split-debuginfo=packed " + (args.RUSTFLAGS or ""); | ||
| } | ||
| // { | ||
| name = args.name or "${finalAttrs.pname}-${finalAttrs.version}"; |
Member
There was a problem hiding this comment.
Do you think it would be possible to just skip this?
Suggested change
| name = args.name or "${finalAttrs.pname}-${finalAttrs.version}"; | |
| # empty, effectively same as: `inherit (finalAttrs) name;` |
Contributor
Author
There was a problem hiding this comment.
Yes. We should let stdenv.mkDerivation handle the name-related attributes whenever pissible.
Contributor
Author
There was a problem hiding this comment.
Update:
No. We need it to define cargoName's default value.
The path changing of scuba and nnd reminds me of the glitches. They both uses pkgsStatic or pkgsCross, which appends platform names to name if specified and pname otherwise.
Contributor
Author
There was a problem hiding this comment.
Second update:
You are right. Let's inherit name, pname and version from the main package's finalAttrs and specify custom name for cargoDeps only when cargoDepsName is specified non-null.
Contributor
Author
There was a problem hiding this comment.
The path change turns out to be inevitable due to how rustPlatform.fetchCargoVendor handle the names. It needs to add prefixes to its name, and changing this behavior results in mass rebuilds.
Luckly, we can keep our current simplification.
nixpkgs-ci
bot
added
the
12.approvals: 1
nixpkgs-ci
bot
added
the
2.status: merge conflict
Contributor
|
@ShamrockLee What is the state of this PR? Why is it a draft? This PR looks reasonable to me. I think it is pretty close to fixing #415397. On the basis of this PR, just changing let
pkgs = import <nixpkgs> { config = { }; overlays = [ ]; };
in
{
kanataBumped = pkgs.kanata.overrideAttrs (old: {
version = assert old.version != "1.10.1"; "1.10.1";
src = old.src.overrideAttrs {
hash = "sha256-jzTK/ZK9UrXTP/Ow662ENBv3cim6klA8+DQv4DLVSNU=";
};
cargoHash = "sha256-qYFt/oHokR+EznugEaE/ZEn26IFVLXePgoYGxoPRi+g=";
});
} |
Contributor
Author
I was waiting for the depending PR, and forgot to mark it ready for review after rebasing. Edit: It turns out I haven't rebased it yet. Update: Rebased. |
ShamrockLee
force-pushed
the
build-rust-package-overriding-pre
branch
from
eb0312e to
a1d15dc
Compare
Contributor
Author
|
GitHub connection seems somewhat unstable currently. CI checks in some of my PRs fail due to network issues. |
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
…riding Make `<rust-package>.cargoDeps` reference the overridden `<rust-package>.src` and other attributes. Let `stdenv.mkDerivation` handle the name of `<rust-package>.cargoDeps`. Make Rust package overriding *possible* before making further design decisions about the `<pkg>.overrideAttrs` interface.
ShamrockLee
force-pushed
the
build-rust-package-overriding-pre
branch
from
a1d15dc to
04c3e0d
Compare
nixpkgs-ci
bot
added
10.rebuild-linux: 0
13 tasks
axelkar
approved these changes
Dec 21, 2025
Member
axelkar
left a comment
axelkar
left a comment
There was a problem hiding this comment.
The code looks looks great, but I haven't tested it.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/overriding-version-cant-find-new-cargohash/31502/10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make .cargoDeps reference the overridden .src and other attributes.
Make Rust package overriding possible before making further design decisions about the
<pkg>.overrideAttrsinterface.This is an initial effort to fixe #415397
This PR depends on:
unpackPhaseandcargoDeps.unpackPhase#435278After rebasing onto it, this PR should cause no rebuild.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.