make pkgsStatic composable by not overriding all of hostPlatform#434771
make pkgsStatic composable by not overriding all of hostPlatform#434771Qyriad wants to merge 1 commit intoNixOS:stagingfrom
pkgsStatic composable by not overriding all of hostPlatform#434771Conversation
`pkgsStatic` was keeping `hostPlatform.parsed`, but all other configured parts of `hostPlatform` (AKA `crossSystem`) were discarded. This fixes that, making `pkgsStatic` work like `pkgsLLVM`, `pkgsZig`, etc. And now `pkgsLLVM.pkgsStatic` is the same as `pkgsStatic.pkgsLLVM` 🎉
I can assure you, none of this is trivial. Your change leads to this: Nope, this is not going to work. As @emilazy pointed out, if you're interested in that, you should look at #380342 and its predecessor #303849 - and some more linked PRs in there. Beware of getting too deep into the rabbit-hole, though... |
|
FWIW I do want to fix the lack of input vs. output separation in platform definitions that would make this kind of operation possible to do in a way that makes sense. (I just think the package variant sets are a dubious interface to begin with.) Unfortunately it is hard. |
|
Yeeeep. Well, I figured it was worth a try to make it mildly-less-broken over a Proper Fix, but alas 😔 |
pkgsStaticwas keepinghostPlatform.parsed, but all other configured parts ofhostPlatform(AKAcrossSystem) were discarded. This fixes that, makingpkgsStaticwork likepkgsLLVM,pkgsZig, etc.Fixes #434755.
I'm not sure what of
pkgsStatic.*orpkgsLLVM.*Hydra builds, so I've targeted staging instead of master.cc @emilazy, @wolfgangwalther; you (reasonably) are against nesting the pkgs variants selectors in the first place, but since the fix is trivial I figure you can take a look
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.