Skip to content

vagrant: 2.4.3 -> 2.4.8#434750

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
unode:vagrant-2.4.8
Aug 21, 2025
Merged

vagrant: 2.4.3 -> 2.4.8#434750
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
unode:vagrant-2.4.8

Conversation

@unode
Copy link
Member

@unode unode commented Aug 18, 2025

Minimal changes to upgrade to vagrant 2.4.8 as 2.4.3 has compatibility issues with VirtualBox 7.1.x

Things done

  • Updated patch 0001-Revert-Merge-pull-request-12225-from-chrisroberts-re.patch for minor code changes and line rearrangements.
  • Updated gems that indicated requiring a newer version
  • Added csv gem - new dependency
  • Removed unofficial-installation-nowarn.patch - it didn't seem to have any effect and patch failed to apply.

Tests

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from tylerjl August 18, 2025 15:34
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 18, 2025
@tylerjl
Copy link
Contributor

tylerjl commented Aug 20, 2025

LGTM. I built and tested the result and things work; I hit these warnings but apparently they're on master so already an existing problem to investigate.

Ignoring debug-1.9.2 because its extensions are not built. Try: gem pristine debug --version 1.9.2
Ignoring racc-1.7.3 because its extensions are not built. Try: gem pristine racc --version 1.7.3
Ignoring rbs-3.4.0 because its extensions are not built. Try: gem pristine rbs --version 3.4.0
Ignoring debug-1.9.2 because its extensions are not built. Try: gem pristine debug --version 1.9.2
Ignoring racc-1.7.3 because its extensions are not built. Try: gem pristine racc --version 1.7.3
Ignoring rbs-3.4.0 because its extensions are not built. Try: gem pristine rbs --version 3.4.0
Ignoring debug-1.9.2 because its extensions are not built. Try: gem pristine debug --version 1.9.2
Ignoring racc-1.7.3 because its extensions are not built. Try: gem pristine racc --version 1.7.3
Ignoring rbs-3.4.0 because its extensions are not built. Try: gem pristine rbs --version 3.4.0

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 20, 2025
@unode
Copy link
Member Author

unode commented Aug 21, 2025

@tylerjl the warnings are present here as well but I didn't find those to be direct dependencies so no attempt to fix it in this PR.

They seem to be harmless. Noisy user experience though.

@SuperSandro2000 SuperSandro2000 merged commit c8ea26c into NixOS:master Aug 21, 2025
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants