Skip to content

or-tools: re-enable tests on x86_64-linux#434740

Merged
wegank merged 1 commit intoNixOS:masterfrom
flokli:or-tools-tests-
Aug 18, 2025
Merged

or-tools: re-enable tests on x86_64-linux#434740
wegank merged 1 commit intoNixOS:masterfrom
flokli:or-tools-tests-

Conversation

@flokli
Copy link
Member

@flokli flokli commented Aug 18, 2025

This needs google/or-tools#4745 to skip SCIP tests if built without SCIP (which we currently do).

The tests currently still fail on aarch64-linux
(google/or-tools#4746), so we only enable for x86_64-linux. It can be re-tested with a more recent version once or-tools is updated.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Aug 18, 2025
@flokli flokli requested a review from bcdarwin August 18, 2025 15:42
Copy link
Member

@bcdarwin bcdarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 18, 2025
@bcdarwin
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 434740
Commit: 00e58f72351910c9e0f7883c92229eeb28464df6


x86_64-linux

✅ 4 packages built:
  • openroad
  • or-tools
  • or-tools.python (python313Packages.ortools, python313Packages.ortools.python)
  • python312Packages.ortools (python312Packages.ortools.python)

This needs google/or-tools#4745 to skip SCIP
tests if built without SCIP (which we currently do).

The tests currently still fail on aarch64-linux
(google/or-tools#4746), so we only enable
for x86_64-linux. It can be re-tested with a more recent version once
or-tools is updated.
@wegank wegank merged commit 2caa62b into NixOS:master Aug 18, 2025
25 of 28 checks passed
@flokli flokli deleted the or-tools-tests- branch August 18, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants