buildRebar3: enable deterministic builds#434713
Merged
adamcstephens merged 2 commits intoNixOS:masterfrom Aug 18, 2025
Merged
Conversation
debugInfoFlag is no longer referenced by anything, as of aef59d8.
The motivation is similar to (and implementation taken partly from) NixOS#271288 --- some rebar3-compiled `.beam` files contain debug information exposing references to `.hrl` files from the Erlang distribution it was compiled with. This results in unnecessary store references. See also NixOS#423588's change to Elixir's `generic-builder.nix` where the same option is used when building to avoid the same issue.
nix-owners
bot
requested review from
Br1ght0ne,
DianaOlympos,
adamcstephens,
ankhers,
gleber,
happysalada and
yurrriq
nixpkgs-ci
bot
added
10.rebuild-linux: 11-100
Member
Author
|
adamcstephens
changed the title
adamcstephens
changed the title
adamcstephens
approved these changes
Aug 18, 2025
Contributor
adamcstephens
left a comment
adamcstephens
left a comment
There was a problem hiding this comment.
The OTP 28 packages are broken on main, so that can be a different fix.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 434713
x86_64-linux
❌ 10 packages failed to build:
- beam28Packages.elvis-erlang
- beam28Packages.erlang-ls
- beam28Packages.pc
- beam28Packages.rebar3-nix
- beam28Packages.rebar3-proper
- beamMinimal28Packages.elvis-erlang
- beamMinimal28Packages.erlang-ls
- beamMinimal28Packages.pc
- beamMinimal28Packages.rebar3-nix
- beamMinimal28Packages.rebar3-proper
✅ 30 packages built:
- akkoma
- beam26Packages.elvis-erlang
- beam26Packages.erlang-ls
- beam26Packages.lfe
- beam26Packages.pc
- beam26Packages.rebar3-nix
- beam26Packages.rebar3-proper
- beam27Packages.elvis-erlang
- beam27Packages.erlang-ls
- beam27Packages.lfe
- beam27Packages.pc
- beam27Packages.rebar3-nix
- beam27Packages.rebar3-proper
- beamMinimal26Packages.elvis-erlang
- beamMinimal26Packages.erlang-ls
- beamMinimal26Packages.lfe
- beamMinimal26Packages.pc
- beamMinimal26Packages.rebar3-nix
- beamMinimal26Packages.rebar3-proper
- beamMinimal27Packages.elvis-erlang
- beamMinimal27Packages.erlang-ls
- beamMinimal27Packages.lfe
- beamMinimal27Packages.pc
- beamMinimal27Packages.rebar3-nix
- beamMinimal27Packages.rebar3-proper
- ejabberd
- mobilizon
- nixpkgs-manual
- pinchflat
- pleroma
aarch64-linux
❌ 13 packages failed to build:
- beam27Packages.erlang-ls
- beam28Packages.elvis-erlang
- beam28Packages.erlang-ls
- beam28Packages.pc
- beam28Packages.rebar3-nix
- beam28Packages.rebar3-proper
- beamMinimal26Packages.erlang-ls
- beamMinimal27Packages.erlang-ls
- beamMinimal28Packages.elvis-erlang
- beamMinimal28Packages.erlang-ls
- beamMinimal28Packages.pc
- beamMinimal28Packages.rebar3-nix
- beamMinimal28Packages.rebar3-proper
✅ 27 packages built:
- akkoma
- beam26Packages.elvis-erlang
- beam26Packages.erlang-ls
- beam26Packages.lfe
- beam26Packages.pc
- beam26Packages.rebar3-nix
- beam26Packages.rebar3-proper
- beam27Packages.elvis-erlang
- beam27Packages.lfe
- beam27Packages.pc
- beam27Packages.rebar3-nix
- beam27Packages.rebar3-proper
- beamMinimal26Packages.elvis-erlang
- beamMinimal26Packages.lfe
- beamMinimal26Packages.pc
- beamMinimal26Packages.rebar3-nix
- beamMinimal26Packages.rebar3-proper
- beamMinimal27Packages.elvis-erlang
- beamMinimal27Packages.lfe
- beamMinimal27Packages.pc
- beamMinimal27Packages.rebar3-nix
- beamMinimal27Packages.rebar3-proper
- ejabberd
- mobilizon
- nixpkgs-manual
- pinchflat
- pleroma
Member
Author
|
Thanks! 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivation is similar to (and implementation taken partly from) #271288 --- some rebar3-compiled
.beamfiles contain debug information exposing references to.hrlfiles from the Erlang distribution it was compiled with. This results in unnecessary store references.See also #423588 change to Elixir's
generic-builder.nixwhere the same option is used when building to avoid the same issue.I'll drop a
nixpkgs-reviewoutput in a moment — AFAICT there are some current failures in master.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.