beamPackages.mixRelease: symlink mixFodDeps with MIX_DEPS_PATH#434632
Merged
adamcstephens merged 1 commit intoNixOS:masterfrom Aug 20, 2025
Merged
beamPackages.mixRelease: symlink mixFodDeps with MIX_DEPS_PATH#434632adamcstephens merged 1 commit intoNixOS:masterfrom
adamcstephens merged 1 commit intoNixOS:masterfrom
Conversation
Contributor
|
This change looks good, can you run a nixpkgs review by any chance ? |
Member
Author
|
Member
Author
|
The failures seem to be unrelated. |
adamcstephens
approved these changes
Aug 20, 2025
Contributor
adamcstephens
left a comment
There was a problem hiding this comment.
Not sure the value in running with the MacOS sandbox in that action, since Hydra doesn't use the sandbox either and it has known issues.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 434632
Commit: 25a4bf11b3e8ed458ee7acedb2cd6552d7001229
aarch64-darwin
✅ 12 packages built:
- akkoma
- beam26Packages.ex_doc
- ex_doc (beam27Packages.ex_doc)
- beam28Packages.ex_doc
- beamMinimal26Packages.ex_doc
- beamMinimal27Packages.ex_doc
- beamMinimal28Packages.ex_doc
- lexical
- livebook
- next-ls
- plausible
- protoc-gen-elixir
Contributor
|
Successfully created backport PR for |
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build is normally done in
$TMPDIR/build1, so../depsis the same as$MIX_DEPS_PATH. But this doesn't hold fornix develop, wherebuildis generally not in$TMPDIR, which will cause the symlink to be invalid. We now use$MIX_DEPS_PATHdirectly which will always be valid.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.
Footnotes
https://nix.dev/manual/nix/2.30/store/building.html#builder-execution ↩