recordbox: 0.10.3 -> 0.10.4

[magneticflux-]

Preemptive PR for the imminent release fixing edestcroix/Recordbox#182. I'll update the commit with the diff and release notes upon release.

@getchoo Should --generate-lockfile be removed from the update script after #425279?

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[sylfn]

0.10.4 will be broken with external jxl cover files because recordbox can't find glycin-loaders. It was broken before, but probably not that evident.

For local development I just copied hack from loupe (

nixpkgs/pkgs/by-name/lo/loupe/package.nix

Lines 60 to 74 in b6b4796

	preConfigure = ''
	# Dirty approach to add patches after cargoSetupPostUnpackHook
	# We should eventually use a cargo vendor patch hook instead
	pushd ../$(stripHash $cargoDeps)/glycin-2.*
	patch -p3 < ${glycin-loaders.passthru.glycinPathsPatch}
	popd
	'';
	preFixup = ''
	# Needed for the glycin crate to find loaders.
	# https://gitlab.gnome.org/sophie-h/glycin/-/blob/0.1.beta.2/glycin/src/config.rs#L44
	gappsWrapperArgs+=(
	--prefix XDG_DATA_DIRS : "${glycin-loaders}/share"
	)
	'';

).

Also, 0.10.4 is now released: release notes

[magneticflux-]

That workaround seems related to #364390, so #364572 should probably be updated once this one is merged.

[getchoo]

LGTM, and thanks for the glycin hack. I'll get around to rebasing the above PR soon so we can get it out of here 😄

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 434018
Commit: 8a9041308cccd3c9ee4ad29b43ff510bd7de4932

---

x86_64-linux

✅ 1 package built:

• recordbox

[getchoo]

@getchoo Should --generate-lockfile be removed from the update script after #425279?

And yeah, totally forgot about it. Feel free to amend it, otherwise I'll just merge later today :)