Skip to content

treewide: remove nixfmt from update scripts' shebangs #433588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wolfgangwalther wants to merge 1 commit into from
Closed

treewide: remove nixfmt from update scripts' shebangs #433588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkgs/by-name/gr/gren/update.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env nix-shell
#!nix-shell -i bash -p cabal2nix curl jq nix-update nixfmt
#!nix-shell -i bash -p cabal2nix curl jq nix-update

set -euo pipefail

Expand Down
2 changes: 1 addition & 1 deletion pkgs/by-name/mu/music-assistant/update-providers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env nix-shell
#!nix-shell -I nixpkgs=./. -i python3 -p "music-assistant.python.withPackages (ps: music-assistant.dependencies ++ (with ps; [ jinja2 packaging ]))" -p nixfmt pyright ruff isort
#!nix-shell -I nixpkgs=./. -i python3 -p "music-assistant.python.withPackages (ps: music-assistant.dependencies ++ (with ps; [ jinja2 packaging ]))" -p pyright ruff isort
import asyncio
import json
import os.path
Expand Down
2 changes: 1 addition & 1 deletion pkgs/development/compilers/dotnet/update.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env nix-shell
#!nix-shell -I nixpkgs=./. -i bash -p curl jq nix gnused nixfmt
#!nix-shell -I nixpkgs=./. -i bash -p curl jq nix gnused
Copy link
Contributor

@corngood corngood Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break dotnet updates because this is called from a pure shell.

Copy link
Contributor

@corngood corngood Aug 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#!nix-shell -I nixpkgs=./. -i bash -p curl jq nix gnused
#!nix-shell --pure -I nixpkgs=./. -i bash -E 'with import <nixpkgs> {}; mkShell { inputsFrom = [ (import <nixpkgs/ci> { nixpkgs = <nixpkgs>; }).fmt.shell ]; packages = [ curl jq nix gnused cacert ]; }'

Copy link
Contributor Author

@wolfgangwalther wolfgangwalther Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break dotnet updates because this is called from a pure shell.

Would an alternative be to remove --pure from the other shell?

Copy link
Contributor

@corngood corngood Aug 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems better to be explicit about the dependencies. If the dependency is missing, it'll do a bunch of time consuming work and then fail without telling the user what they did wrong. Also if they happen to have the wrong treefmt/nixfmt in PATH already, it'll do something bad without failing.

# shellcheck shell=bash

set -Eeuo pipefail
Expand Down
2 changes: 1 addition & 1 deletion pkgs/os-specific/linux/kernel/update-xanmod.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env nix-shell
#!nix-shell -i bash -p bash nix-prefetch curl jq gawk gnused nixfmt
#!nix-shell -i bash -p bash nix-prefetch curl jq gawk gnused

set -euo pipefail

Expand Down
2 changes: 1 addition & 1 deletion pkgs/servers/home-assistant/update-component-packages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#! /usr/bin/env nix-shell
#! nix-shell -i python3 -p "python3.withPackages (ps: with ps; [ packaging rich ])" -p pyright ruff isort nixfmt
#! nix-shell -i python3 -p "python3.withPackages (ps: with ps; [ packaging rich ])" -p pyright ruff isort
#
# This script downloads Home Assistant's source tarball.
# Inside the homeassistant/components directory, each integration has an associated manifest.json,
Expand Down
2 changes: 1 addition & 1 deletion pkgs/servers/x11/xorg/update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env nix-shell
#!nix-shell --pure --keep NIX_PATH -i python3 -p nix git nixfmt "python3.withPackages (ps: [ ps. packaging ps.beautifulsoup4 ps.requests ])"
#!nix-shell -i python3 -p nix git "python3.withPackages (ps: [ ps. packaging ps.beautifulsoup4 ps.requests ])"

# Usage: Run ./update.py from the directory containing tarballs.list. The script checks for the
# latest versions of all packages, updates the expressions if any update is found, and commits
Expand Down
Loading