tclPackages: define tcl8Packages and tcl9Packages#433414
Conversation
| tcl-8_6 = callPackage ../development/interpreters/tcl/8.6.nix { }; | ||
| tcl-9_0 = callPackage ../development/interpreters/tcl/9.0.nix { }; | ||
|
|
||
| # We don't need versioned package sets thanks to the tcl stubs mechanism |
There was a problem hiding this comment.
Let's keep a comment like this to explain why we don't also have minor versions:
| # We don't need versioned package sets thanks to the tcl stubs mechanism | |
| # We don't need versioned package sets for minor versions thanks to the tcl stubs mechanism |
|
|
||
| # We don't need versioned package sets thanks to the tcl stubs mechanism | ||
| tclPackages = recurseIntoAttrs (callPackage ./tcl-packages.nix { }); | ||
| tclPackages = tcl8Packages; |
There was a problem hiding this comment.
For consistency with the other sets, I think we should either expose the versioned or the unversioned set, not both
| tclPackages = tcl8Packages; | |
| tclPackages = dontRecurseIntoAttrs tcl8Packages; |
There was a problem hiding this comment.
I agree, but how should callPackage select a set for "applications"?
How about this?
{ lib
, tclPackages ? tcl9Packages,
, tcl9Packages
}: nullThere was a problem hiding this comment.
I'm not sure I understand your question. recurseIntoAttrs/dontRecurseIntoAttrs is just a hint for nix search / https://search.nixos.org / other tools. The package set is still available for use in nix code, it's just hidden from display in some places.
There was a problem hiding this comment.
The question is how should packages outside the scope of a tclNPackages bring one into scope. Things like Tcl/Tk applications.
There was a problem hiding this comment.
Sorry, I missed the notification ^_^"
As far as I can see with other ecosystems we use the unversioned set by default unless the program does not compile with the default version. We can do the same.
It should be possible to build packages against Tcl-9, regardless if stubs are present in extensions.
Ping @fgaz
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.