opencascade-occt: add optional vtk dependency#433252
Conversation
52f9f52 to
d900136
Compare
d900136 to
8c82549
Compare
|
Thanks, I will take some time to build occtWithVtk and review this PR. When setting withVtk = true and enableException = true, occtWithVtk differs from the one defined in |
Hmm, is |
8c82549 to
cfee71f
Compare
|
I agree! I think I would prefer |
|
Hmm, just tried to add WDYT about having |
ef0bba4 to
1e9c17e
Compare
1e9c17e to
58b49e1
Compare
|
If both python3Packages.vtk and vtk are available, we are refering to python3Packages.vtk first when using inputs vtk in python3Packages scope. What we really need in cadquery-ocp is the vanilla pkgs.vtk that dont have mpiSupport/pythonSupport/qtSupport. By adding a variant of opencascade-occtWithVtk in all-packages.nix we can use opencascade-occtWithVtk in cadquery-ocp directly and avoid using vtkWithoutMPI. Also, adding variant opencascade-occtWithVtk makes this standalone pull request complete and we can check we do build opencascade-occtWithVtk by ofborg ci or running nixpkgs-review. |
Yes, but unless I'm missing something we need |
|
I will check if cadquery-ocp do needs vtk with pythonSupport/ without mpiSupport. |
58b49e1 to
a7a8307
Compare
Yes, cadquery require vtk with pythonSupport and without mpiSupport. |
|
To clarify, is the plan to use python3Packages.vtk in opencascade-occtWithVtk? Or are we going with vanilla pkgs.vtk in opencascade-occtWithVtk and using python3Packages.vtk in cadquery-ocp, which itself would depend on pkgs.vtk indirectly through opencascade-occtWithVtk? Sorry for the dumb questions, just generally unsure about nixpkgs conventions when it comes to multiple variants of dependencies in the same closure. |
8634195 to
c8515e7
Compare
|
db5e9d6 to
1d1317c
Compare
41eea0c to
6d78816
Compare
c9c6d7a to
a6cdf7c
Compare
a6cdf7c to
fff17e7
Compare
fff17e7 to
633d7c5
Compare
633d7c5 to
205d89f
Compare
|
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5832 |
|
python3Packages.{gstools,pykrige} are known broken on aarch64-darwin. |
|
|
These pythonPackages are all known failed on hydra since last bulk python upgrade. |
|
|
Pull Request is not mergeable
build123d (#433247) requires
opencascade-occtbuilt withvtk. These changes add an attribute for that dependency (withVtk). Additionally, I enabled C++ exceptions, as they are disabled by default for release builds andopencascade-occt's dependents in nixpkgs seem to require them.CC @qbisi
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.