duckstation-unofficial: init at 0.1-9483#433242
Conversation
a353c8a to
5b1d853
Compare
|
I want to work on adding darwin support (from |
5b1d853 to
ea04511
Compare
ea04511 to
9adbc6f
Compare
|
Removed the git workaround patch, duckstation doesn't require the git variables to be filled in and the only obvious change is that the window title and about dialog don't include the revision. This allows for removing the New Changes:Added Darwin build (migrated from the earlier Added an update script which updates duckstation and all corresponding vendored subpackages. |
18b5372 to
a8cb4a9
Compare
|
Fixed: |
a8cb4a9 to
e2aea78
Compare
|
I added a new previous commit that enables building shared libraries for the |
|
Oh wow that causes a huge rebuild on darwin, force pushed to guard it behind a linux host. (didn't work initially because of me changing the |
44ce542 to
bd09cfc
Compare
keenanweaver
left a comment
There was a problem hiding this comment.
From what I can tell, everything is working as intended. All options, cover art downloader, etc.
The only 'issue' I have is it is loading the wrong KDE style/Breeze theme in the file picker. To see it quickly, click System -> Start File.
Probably something with my settings, but just wanted to point it out.
nixpkgs-review result for #433242
Generated using nixpkgs-review-gha
Command: nixpkgs-review pr 433242
Logs: https://github.com/keenanweaver/nixpkgs-review-gha/actions/runs/17046393147
x86_64-linux
✅ 4 packages built:
- duckstation-unofficial
- gpupad
- spirv-cross
- taisei
aarch64-linux
✅ 4 packages built:
- duckstation-unofficial
- gpupad
- spirv-cross
- taisei
x86_64-darwin (sandbox = true)
✅ 1 package built:
- duckstation-unofficial
aarch64-darwin (sandbox = true)
✅ 1 package built:
- duckstation-unofficial
bd09cfc to
8646204
Compare
|
New changes
Please test to make sure that cheats/patches do work. I was able to give myself unlimited lives in Crash Bandicoot 1 and the UI reported cheats being loaded in. |
c797ea9 to
6998783
Compare
This is also happening to me under KDE 6.4 in nixpkgs-unstable. Other than that, everything else works fine, including cheats and shaders. |
|
I believe this must be because Duckstation doesn't use portals for its file picker instead either calling the Qt file picker or using the gtk file picker because on GNOME I'm not getting the correct adwaita file picker. Duckstation will probably never see a full wayland port given the project struggled with it for years now. |
|
Force pushed and rebased on main
|
6998783 to
66fcb37
Compare
66fcb37 to
cb8e556
Compare
|
I removed both calls to I'm still looking into doing the same for shaderc which requires migrating the patches for building the cmake package that was in the vendored source so far I'm getting stuck on CMake errors. Updated to a newer release of duckstation and also updated sub-packages. |
This is a soft-revert of duckstation's removal in #430501 (revision: f5cb574) and placing it under the `duckstation-unofficial` attribute which supports both linux and darwin platforms, most of the previously submitted code and patches still apply and this commit squashes everything together into one package file and thus is a combination of work done by different authors, listed below to the best of my ability: Co-developed-by: Marcin Serwin <marcin@serwin.dev> Co-developed-by: Anderson Torres <torres.anderson.85@protonmail.com> Co-developed-by: OPNA2608 <opna2608@protonmail.com> Co-developed-by: qubitnano <146656568+qubitnano@users.noreply.github.com> Co-developed-by: PedroHLC ☭ <root@pedrohlc.com> Co-developed-by: Artturin <Artturin@artturin.com> Co-developed-by: Guillaume Bouchard <guillaum.bouchard@gmail.com>
cb8e556 to
fdbdc03
Compare
|
Closing in favor of #444821 |


Context:
This PR adds the
duckstation-unofficialpackage attributes which ships the latest version of duckstation under the CC-BY-NC-ND 4.0 which is considered unfree by nixpkgs and thus will not be built by hydra.My stance on copyright and nixpkgs has changed since I first started contributing as I've started reading more of the community's opinions and my own have developed. My current opinion is that we aren't in violation of any copyright statute by distributing a derivation build script to package duckstation. Upstream simply has no right to forbid the distribution of this derivation nor the right to prevent users from using it. Even if upstream decided to make duckstation closed source and all public links closed, we would still be in our right to distribute a wrapper over the publicly available appimage release.
When launching this package, one is greeted with a warning about using an unofficial build and directs users to the official releases by upstream, this warning can be disabled for subsequent launches.
Whether or not this PR is suitable to be merged, I'm still content with publishing a usable derivation builder for duckstation that people can use out-of-tree if they so wish to.
I've tested running my copy of Crash Bandicoot 1 using a CRT shader on Vulkan.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.