Skip to content

treewide: drop usage of nixfmt-rfc-style alias#433100

Merged
alyssais merged 1 commit intoNixOS:masterfrom
SuperSandro2000:drop-nixfmt-rfc-alias
Aug 12, 2025
Merged

treewide: drop usage of nixfmt-rfc-style alias#433100
alyssais merged 1 commit intoNixOS:masterfrom
SuperSandro2000:drop-nixfmt-rfc-alias

Conversation

@SuperSandro2000
Copy link
Member

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@alyssais alyssais enabled auto-merge (rebase) August 12, 2025 18:46
@alyssais alyssais merged commit c19b2c3 into NixOS:master Aug 12, 2025
44 of 48 checks passed
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: kernel The Linux kernel 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 8.has: documentation This PR adds or changes documentation labels Aug 12, 2025
@SuperSandro2000 SuperSandro2000 deleted the drop-nixfmt-rfc-alias branch August 13, 2025 14:20
@jfly
Copy link
Contributor

jfly commented Aug 13, 2025

@MattSturgeon, is this change compatible with the intent of #425583?

@MattSturgeon
Copy link
Contributor

MattSturgeon commented Aug 13, 2025

@MattSturgeon, is this change compatible with the intent of #425583?

No, this should be reverted as it is too premature to stop using the alias in documentation, nix-shell -p, etc.

jfly added a commit to jfly/nixpkgs that referenced this pull request Aug 13, 2025
This reverts commit c19b2c3.

As per the discussion
[here](NixOS#433100 (comment)),
it's too early to drop usage of the alias in documentation.

Removing the references is tracked by
<NixOS#425583>, which a member of the
Nix Formatting team will do when the time is right.
@infinisil
Copy link
Member

Please make sure to request a review by the formatting team for such changes ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: kernel The Linux kernel 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants