workflows/pr: fix condition for no-pr-failures job#433097
Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom Aug 12, 2025
Merged
workflows/pr: fix condition for no-pr-failures job#433097wolfgangwalther merged 1 commit intoNixOS:masterfrom
wolfgangwalther merged 1 commit intoNixOS:masterfrom
Conversation
nix-owners
bot
requested review from
MattSturgeon,
Mic92,
philiptaron and
zowoq
The `cancelled()` condition seems to only apply when *the whole workflow* was cancelled. This is not the case when a single job is cancelled due to timeout. We can replicate this by checking each needs.result manually.
wolfgangwalther
force-pushed
the
ci-no-pr-failures
branch
from
c1748e6 to
d1bb354
Compare
philiptaron
approved these changes
Aug 12, 2025
Contributor
|
What's going on with that eval error at 3min? Timeout? |
nixpkgs-ci
bot
added
the
12.approvals: 1
Contributor
Author
Nope, that's an API error from GitHub. Should be gone when I re-run it. |
nixpkgs-ci
bot
added
6.topic: continuous integration
Contributor
|
Successfully created backport PR for |
1 task
github-actions
bot
added
the
8.has: port to stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cancelled()condition seems to only apply when the whole workflow was cancelled. This is not the case when a single job is cancelled due to timeout.We can replicate this by checking each
needs.resultmanually.Fixes #433060 (comment). This time tested in my fork in all 3 conditions.
Things done
Add a 👍 reaction to pull requests you find important.