Skip to content

[Backport release-25.05]: nixos/slurm: remove mysql/InnoDB tuning settings, unbreak test#432790

Merged
wolfgangwalther merged 1 commit intoNixOS:release-25.05from
markuskowa:fix-slurm-test-25.05
Aug 14, 2025
Merged

[Backport release-25.05]: nixos/slurm: remove mysql/InnoDB tuning settings, unbreak test#432790
wolfgangwalther merged 1 commit intoNixOS:release-25.05from
markuskowa:fix-slurm-test-25.05

Conversation

@markuskowa
Copy link
Member

The tuning settings are recommended for production setups: (https://slurm.schedmd.com/accounting.html#slurm-accounting-configuration-before-build)

These are not needed in the test and broke the MySQL service.

(cherry picked from commit 68d450a)

manual back port of #415523

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

The tuning settings are recommended for production setups:
(https://slurm.schedmd.com/accounting.html#slurm-accounting-configuration-before-build)

These are not needed in the test and broke the MySQL service.

(cherry picked from commit 68d450a)
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 4.workflow: backport This targets a stable branch labels Aug 11, 2025
@wolfgangwalther
Copy link
Contributor

Triggering CI again after fixing #433074.

@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 12, 2025
@markuskowa
Copy link
Member Author

@ofborg build slurm
@ofborg test slurm

@wolfgangwalther
Copy link
Contributor

That didn't work out the first time, ofborg had internal problems. Let's try again.

@ofborg build slurm
@ofborg test slurm

@markuskowa
Copy link
Member Author

@wolfgangwalther it seems that ofborg is still out of order:

 error: cannot open connection to remote store 'daemon': error: reading from file: Connection reset by peer

@wolfgangwalther
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 432790 --package slurm.tests
Commit: 587d72880ab28d2c5ee8b8f5c5bd52661e868626


x86_64-linux

✅ 1 package built:
  • slurm.tests.slurm

@wolfgangwalther wolfgangwalther merged commit 483bf4e into NixOS:release-25.05 Aug 14, 2025
92 of 101 checks passed
@markuskowa markuskowa deleted the fix-slurm-test-25.05 branch August 14, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.workflow: backport This targets a stable branch 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants