Skip to content

kail: init at 0.6.0#43278

Merged
nlewo merged 1 commit intoNixOS:masterfrom
xtruder:pkgs/kail/init
Jul 11, 2018
Merged

kail: init at 0.6.0#43278
nlewo merged 1 commit intoNixOS:masterfrom
xtruder:pkgs/kail/init

Conversation

@offlinehacker
Copy link
Contributor

@offlinehacker offlinehacker commented Jul 10, 2018

Kail is kubernetes log viewer

@offlinehacker offlinehacker force-pushed the pkgs/kail/init branch 2 times, most recently from a8628aa to 97bb53f Compare July 10, 2018 10:27
@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 10, 2018
@GrahamcOfBorg
Copy link

GrahamcOfBorg commented Jul 10, 2018

Success on aarch64-linux (full log)

Attempted: kail

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/k30x0q0pjz7gdxkibh3lmiaqcswf8jim-kail-0.6.0-bin/bin
patching script interpreter paths in /nix/store/k30x0q0pjz7gdxkibh3lmiaqcswf8jim-kail-0.6.0-bin
checking for references to /build in /nix/store/k30x0q0pjz7gdxkibh3lmiaqcswf8jim-kail-0.6.0-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/s7vp3li81qa35crh2hk38mfraw2l0qcw-kail-0.6.0
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/s7vp3li81qa35crh2hk38mfraw2l0qcw-kail-0.6.0
/nix/store/s7vp3li81qa35crh2hk38mfraw2l0qcw-kail-0.6.0/share/go/src/github.com/boz/kail/_example/demo.sh: interpreter directive changed from "/bin/sh" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/sh"
/nix/store/s7vp3li81qa35crh2hk38mfraw2l0qcw-kail-0.6.0/share/go/src/github.com/boz/kail/release.sh: interpreter directive changed from "/bin/bash" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/s7vp3li81qa35crh2hk38mfraw2l0qcw-kail-0.6.0...
/nix/store/k30x0q0pjz7gdxkibh3lmiaqcswf8jim-kail-0.6.0-bin

@GrahamcOfBorg
Copy link

GrahamcOfBorg commented Jul 10, 2018

Success on x86_64-linux (full log)

Attempted: kail

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/ylz8sl8jykcv15askbfib2yx9fnlv1hr-kail-0.6.0-bin/bin 
patching script interpreter paths in /nix/store/ylz8sl8jykcv15askbfib2yx9fnlv1hr-kail-0.6.0-bin
checking for references to /tmp/nix-build-kail-0.6.0.drv-0 in /nix/store/ylz8sl8jykcv15askbfib2yx9fnlv1hr-kail-0.6.0-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/mf3g7rp64iqjrkdwa8lwf04xdq6gxil3-kail-0.6.0
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/mf3g7rp64iqjrkdwa8lwf04xdq6gxil3-kail-0.6.0
/nix/store/mf3g7rp64iqjrkdwa8lwf04xdq6gxil3-kail-0.6.0/share/go/src/github.com/boz/kail/release.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/mf3g7rp64iqjrkdwa8lwf04xdq6gxil3-kail-0.6.0/share/go/src/github.com/boz/kail/_example/demo.sh: interpreter directive changed from "/bin/sh" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/sh"
checking for references to /tmp/nix-build-kail-0.6.0.drv-0 in /nix/store/mf3g7rp64iqjrkdwa8lwf04xdq6gxil3-kail-0.6.0...
/nix/store/ylz8sl8jykcv15askbfib2yx9fnlv1hr-kail-0.6.0-bin

nlewo
nlewo requested changes Jul 10, 2018
View reviewed changes
pkgs/tools/networking/kail/default.nix Outdated
Copy link
Member

@nlewo nlewo Jul 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you capitalize the first letter of the desc?

pkgs/tools/networking/kail/default.nix Outdated
Copy link
Member

@nlewo nlewo Jul 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to checkout the release before generating dependencies. It seems we are building the v0.6.0 with the deps of master.

Copy link
Contributor Author

@offlinehacker offlinehacker Jul 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added comment to checkout actual version

pkgs/tools/networking/kail/default.nix Outdated
Copy link
Member

@nlewo nlewo Jul 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to remove useless arguments.

pkgs/tools/networking/kail/default.nix Outdated
Copy link
Member

@nlewo nlewo Jul 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rev = "v${version}"

nlewo
nlewo reviewed Jul 10, 2018
View reviewed changes
pkgs/tools/networking/kail/default.nix Outdated
Copy link
Member

@nlewo nlewo Jul 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quotes are useless.

Copy link
Member

@infinisil infinisil Jul 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though I was the one to open that PR, there was a significant amount of people not liking it: #27809 (comment)

Copy link
Member

@nlewo nlewo Jul 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like too this! I just read your comment and I could also add it's hard for new comers to know this syntax. But I always tries to refer to the manual which doesn't use quote for urls:/

@offlinehacker
Copy link
Contributor Author

offlinehacker commented Jul 11, 2018

Fixed all the changes requested above

@GrahamcOfBorg
Copy link

GrahamcOfBorg commented Jul 11, 2018

Success on aarch64-linux (full log)

Attempted: kail

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/6q4sn3q6msk5qf7r12j30v16n4hmgxh9-kail-0.6.0-bin/bin
patching script interpreter paths in /nix/store/6q4sn3q6msk5qf7r12j30v16n4hmgxh9-kail-0.6.0-bin
checking for references to /build in /nix/store/6q4sn3q6msk5qf7r12j30v16n4hmgxh9-kail-0.6.0-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/41sliy8qdsjvfsmz4fgdbras63nms2rm-kail-0.6.0
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/41sliy8qdsjvfsmz4fgdbras63nms2rm-kail-0.6.0
/nix/store/41sliy8qdsjvfsmz4fgdbras63nms2rm-kail-0.6.0/share/go/src/github.com/boz/kail/_example/demo.sh: interpreter directive changed from "/bin/sh" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/sh"
/nix/store/41sliy8qdsjvfsmz4fgdbras63nms2rm-kail-0.6.0/share/go/src/github.com/boz/kail/release.sh: interpreter directive changed from "/bin/bash" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/41sliy8qdsjvfsmz4fgdbras63nms2rm-kail-0.6.0...
/nix/store/6q4sn3q6msk5qf7r12j30v16n4hmgxh9-kail-0.6.0-bin

@GrahamcOfBorg
Copy link

GrahamcOfBorg commented Jul 11, 2018

Success on x86_64-linux (full log)

Attempted: kail

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/7rxp0qb5zlnqv0dyz7aqjifdjllr2d50-kail-0.6.0-bin/bin 
patching script interpreter paths in /nix/store/7rxp0qb5zlnqv0dyz7aqjifdjllr2d50-kail-0.6.0-bin
checking for references to /tmp/nix-build-kail-0.6.0.drv-0 in /nix/store/7rxp0qb5zlnqv0dyz7aqjifdjllr2d50-kail-0.6.0-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/pljwwff3i69wz113bvdk3vqg2zacj4v3-kail-0.6.0
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/pljwwff3i69wz113bvdk3vqg2zacj4v3-kail-0.6.0
/nix/store/pljwwff3i69wz113bvdk3vqg2zacj4v3-kail-0.6.0/share/go/src/github.com/boz/kail/release.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/pljwwff3i69wz113bvdk3vqg2zacj4v3-kail-0.6.0/share/go/src/github.com/boz/kail/_example/demo.sh: interpreter directive changed from "/bin/sh" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/sh"
checking for references to /tmp/nix-build-kail-0.6.0.drv-0 in /nix/store/pljwwff3i69wz113bvdk3vqg2zacj4v3-kail-0.6.0...
/nix/store/7rxp0qb5zlnqv0dyz7aqjifdjllr2d50-kail-0.6.0-bin

@nlewo
Copy link
Member

nlewo commented Jul 11, 2018

Thanks!

@nlewo nlewo merged commit 1539167 into NixOS:master Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nlewo nlewo nlewo requested changes

@infinisil infinisil infinisil left review comments

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@offlinehacker @GrahamcOfBorg @nlewo @infinisil