Skip to content

osm-gps-map: 1.2.0 -> unstable-2025-04-17#432585

Closed
cafkafk wants to merge 1 commit intoNixOS:masterfrom
cafkafk:fix-insecure-osm-gps-map
Closed

osm-gps-map: 1.2.0 -> unstable-2025-04-17#432585
cafkafk wants to merge 1 commit intoNixOS:masterfrom
cafkafk:fix-insecure-osm-gps-map

Conversation

@cafkafk
Copy link
Member

@cafkafk cafkafk commented Aug 10, 2025

Signed-off-by: Christina Sørensen ces@fem.gg

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@cafkafk
Copy link
Member Author

cafkafk commented Aug 10, 2025

So this is a bit of a mess, the last release was in 2021, but later libsoup-3 was added in 2023 (still without a release).

To complicate things further, the tarball release had run the autogen.sh script in advance, which is likely why previously we were fetching a tarball instead of using fetchFromGitHub. Without having run this advance, not only do we need to extend the install steps to run it, we also need to add nescesarry dependencies to do so.

To make it worse, the script seems to require git functionality, meaning we may have to patch this to get it working...

error: builder for '/nix/store/2bm2rnhf5sik72y04cvsbpgrv2bzfl66-osm-gps-map-unstable-2025-04-17.drv' failed with exit code 1;
       last 25 log lines:
       > m4/ltoptions.m4:148: AC_LIBTOOL_WIN32_DLL is expanded from...
       > configure.ac:19: the top level
       > configure.ac:19: warning: AC_LIBTOOL_WIN32_DLL: Remove this warning and the call to _LT_SET_OPTION when you
       > configure.ac:19: put the 'win32-dll' option into LT_INIT's first parameter.
       > ./lib/autoconf/general.m4:2434: AC_DIAGNOSE is expanded from...
       > m4/ltoptions.m4:148: AC_LIBTOOL_WIN32_DLL is expanded from...
       > configure.ac:19: the top level
       > configure.ac:20: warning: The macro 'AM_PROG_LIBTOOL' is obsolete.
       > configure.ac:20: You should run autoupdate.
       > m4/libtool.m4:101: AM_PROG_LIBTOOL is expanded from...
       > configure.ac:20: the top level
       > configure.ac:63: warning: AC_OUTPUT should be used without arguments.
       > configure.ac:63: You should run autoupdate.
       > autoreconf: running: /nix/store/0qmqybsb86p5g6vqxj992grj9hyh72wa-autoconf-2.72/bin/autoheader --force
       > autoreconf: running: automake --add-missing --copy --force-missing
       > configure.ac:17: installing './compile'
       > configure.ac:19: installing './config.guess'
       > configure.ac:19: installing './config.sub'
       > configure.ac:9: installing './install-sh'
       > configure.ac:9: installing './missing'
       > examples/Makefile.am: installing './depcomp'
       > autoreconf: './install-sh' is updated
       > autoreconf: Leaving directory '.'
       > ./configure: line 2625: syntax error near unexpected token `git-directory'
       > ./configure: line 2625: `AX_IS_RELEASE(git-directory)'
       For full logs, run 'nix log /nix/store/2bm2rnhf5sik72y04cvsbpgrv2bzfl66-osm-gps-map-unstable-2025-04-17.drv'.

I've hit the point where I'm questioning if taking maintainership of that project would be an easier solution, and I'm not even a gnome user.

@nixpkgs-ci nixpkgs-ci bot added 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Aug 10, 2025
Signed-off-by: Christina Sørensen <ces@fem.gg>
@cafkafk cafkafk force-pushed the fix-insecure-osm-gps-map branch from 6885ac3 to 9ae1b28 Compare August 10, 2025 18:54
@cafkafk cafkafk linked an issue Aug 10, 2025 that may be closed by this pull request
3 tasks
@cafkafk
Copy link
Member Author

cafkafk commented Aug 10, 2025

I just saw #429473 so meh, not worth doing this

@cafkafk cafkafk closed this Aug 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

darktable: dependency libsoup-2.4 insecure

1 participant