Skip to content

Backport 431468 to release 25.05#432382

Closed
corngood wants to merge 6494 commits intoNixOS:masterfrom
corngood:backport-431468-to-release-25.05
Closed

Backport 431468 to release 25.05#432382
corngood wants to merge 6494 commits intoNixOS:masterfrom
corngood:backport-431468-to-release-25.05

Conversation

@corngood
Copy link
Contributor

@corngood corngood commented Aug 9, 2025

Backport of #431468

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

zowoq and others added 30 commits August 5, 2025 22:10
prevent the bot from sending PRs where the only upstream change is a flake.lock update

(cherry picked from commit 3ebec4d)
(cherry picked from commit 8900b9d)
(cherry picked from commit be69bd0)
(cherry picked from commit 4ee5f6f)
(cherry picked from commit d4bbd68)
(cherry picked from commit 69cec1b)
(cherry picked from commit 25c6858)
Test for linking had to be removed because now the linking is more
complex and it would take too much mocking to test it.

The test in question was moved to the dashboard codebase that is
closed-source, if that helps in any way.

(cherry picked from commit a667834)
(cherry picked from commit e066e4e)
(cherry picked from commit 229dc3a)
(cherry picked from commit e2cb442)
(cherry picked from commit ffb03c8)
wolfgangwalther and others added 27 commits August 9, 2025 17:22
This reverts commit f2648b2.

While the idea to never use swap was fine, in practice this meant that
when nix ran OOM, some other process was killed instead. This lead to
the job not being possible to be cancelled anymore and thus needing to
timeout, before subsequent jobs could be scheduled. This can take up to
6 hours for GitHub Actions by default.

Re-enabling the swap file to catch this case more gracefully. It's still
the goal to never actually *use* the swap file during Eval and just a
safeguard.

Keeping the changed chunkSize and not reverting it - this makes it
slightly less likely to hit the swap file when running with Lix.

(cherry picked from commit 9cde368)
None of our jobs is expected to run for 6 hours, the GitHub limit. These
limits are generous and take into accounts that some jobs need to wait
for others.

If jobs exceed these times, most likely something else is wrong and
needs investigation.

(cherry picked from commit 436d541)
The package was previously busted: there were random things in
result/usr, which is very much wrong. I rewrote it to use the meson
build since the makefile is pretty highly busted.

(cherry picked from commit cea6125)
@corngood corngood closed this Aug 9, 2025
@nix-owners
Copy link

nix-owners bot commented Aug 9, 2025

The PR's base branch is set to master, but 6490 commits from the release-25.05 branch are included. Make sure you know the right base branch for your changes, then:

  • If the changes should go to the release-25.05 branch, change the base branch to release-25.05
  • If the changes should go to the master branch, rebase your PR onto the merge base with the master branch:
    # git rebase --onto $(git merge-base upstream/master HEAD) $(git merge-base upstream/release-25.05 HEAD)
    git rebase --onto b965e4c283060415956ccd39eee4ca34a6a56cf8 c5f08b62ed75415439d48152c2a784e36909b1bc
    git push --force-with-lease

@corngood corngood deleted the backport-431468-to-release-25.05 branch August 10, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.