Skip to content

koodo-reader: set mac signing identity to null #432381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pbsds merged 1 commit into from
Aug 11, 2025
Merged

koodo-reader: set mac signing identity to null #432381

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions pkgs/by-name/ko/koodo-reader/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,6 @@ stdenv.mkDerivation (finalAttrs: {

env.ELECTRON_SKIP_BINARY_DOWNLOAD = "1";

# disable code signing on Darwin
env.CSC_IDENTITY_AUTO_DISCOVERY = "false";

postBuild = ''
cp -r ${electron.dist} electron-dist
chmod -R u+w electron-dist
Expand All @@ -68,7 +65,9 @@ stdenv.mkDerivation (finalAttrs: {
export npm_config_nodedir=${electron.headers}
npm run postinstall

# Explicitly set identity to null to avoid signing on darwin
yarn --offline run electron-builder --dir \
-c.mac.identity=null \
-c.electronDist=electron-dist \
-c.electronVersion=${electron.version}
'';
Expand Down
Loading