Skip to content

ansel: fix compilation, remove libsoup_2_4 and make improvements#432089

Merged
wolfgangwalther merged 8 commits intoNixOS:masterfrom
mBornand:fix-ansel2
Aug 18, 2025
Merged

ansel: fix compilation, remove libsoup_2_4 and make improvements#432089
wolfgangwalther merged 8 commits intoNixOS:masterfrom
mBornand:fix-ansel2

Conversation

@mBornand
Copy link
Contributor

@mBornand mBornand commented Aug 8, 2025 •
edited
Loading

This fixes compilation errors of ansel.
Secondly this removes a dependency to libsoup_2_4 that is insecure and unmaintained. (#360897)
To remove libsoup_2_4 completely from ansel we depend on (#429473) to remove it from osm-gps-map.
The PR was tested with and without #429473.

  • Fixes the compilation of ansel
  • Use the standard version of libavif
  • Sort the packages input to make more readable
  • Add missing dependencies
  • Remove pcre from buildInputs since it is unused
  • Tells the build system that we make a package and not a local build (important for SIMD operations)
  • Propose to add myself as maintainer

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle! 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Aug 8, 2025
@mBornand
Copy link
Contributor Author

mBornand commented Aug 8, 2025 •
edited
Loading

nixpkgs-review result (with NIXPKGS_ALLOW_INSECURE=1)

Generated using nixpkgs-review.

Command: nixpkgs-review pr 432089 --package ansel
Commit: d25b272fa93e2d96b533af0c92a5795646793738

x86_64-linux

✅ 1 package built:
  • ansel

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 8, 2025
@nixpkgs-ci nixpkgs-ci bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Aug 11, 2025
@mBornand
Copy link
Contributor Author

mBornand commented Aug 11, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 432089
Commit: b3c542c37eebcfba791fe347c36e7100e4fcd692

x86_64-linux

✅ 1 package built:
  • ansel

@mBornand
Copy link
Contributor Author

mBornand commented Aug 11, 2025 •
edited
Loading

Since #429473 is merged and osm-gps-map doesn't use libsoup_2_4, this pr removes the insecure flag on ansel.

CI failures seem to be unrelated to this pr.

wolfgangwalther
wolfgangwalther reviewed Aug 17, 2025
View reviewed changes
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 17, 2025
@mBornand
Copy link
Contributor Author

mBornand commented Aug 17, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 432089
Commit: 2b87d8f8ea4ae27c4473c086e44437f2d44cff29

x86_64-linux

✅ 11 packages built:
  • ansel
  • darktable
  • jing (jing-trang)
  • photoprism
  • saxon
  • saxon-he (saxon_12-he)
  • saxon_11-he
  • saxon_9-he
  • saxonb (saxonb_8_8)
  • saxonb_9_1
  • xmloscopy

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 17, 2025
@nix-owners nix-owners bot requested review from mrVanDalo, paperdigits and rvl August 17, 2025 21:52
@nix-owners nix-owners bot requested review from flosse and freyacodes August 17, 2025 21:52
@paperdigits
Copy link
Contributor

paperdigits commented Aug 18, 2025 via email •
edited by wolfgangwalther
Loading

@mBornand
Copy link
Contributor Author

mBornand commented Aug 18, 2025

For Saxon, why not do the same thing darktable is doing on master?

@paperdigits This option is also okay for me. I just think a symlink is lighter and does the same job. Or do you see a reason we should not do it this way?

wolfgangwalther
wolfgangwalther reviewed Aug 18, 2025
View reviewed changes
wolfgangwalther
wolfgangwalther reviewed Aug 18, 2025
View reviewed changes
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 432089 --skip-package darktable
Commit: 64ba28065a394c6ca93c3b855e40de34dad2dcd2

x86_64-linux

✅ 10 packages built:
  • ansel
  • jing (jing-trang)
  • photoprism
  • saxon
  • saxon-he (saxon_12-he)
  • saxon_11-he
  • saxon_9-he
  • saxonb (saxonb_8_8)
  • saxonb_9_1
  • xmloscopy

aarch64-linux

✅ 10 packages built:
  • ansel
  • jing (jing-trang)
  • photoprism
  • saxon
  • saxon-he (saxon_12-he)
  • saxon_11-he
  • saxon_9-he
  • saxonb (saxonb_8_8)
  • saxonb_9_1
  • xmloscopy

x86_64-darwin

✅ 8 packages built:
  • jing (jing-trang)
  • saxon
  • saxon-he (saxon_12-he)
  • saxon_11-he
  • saxon_9-he
  • saxonb (saxonb_8_8)
  • saxonb_9_1
  • xmloscopy

aarch64-darwin

✅ 8 packages built:
  • jing (jing-trang)
  • saxon
  • saxon-he (saxon_12-he)
  • saxon_11-he
  • saxon_9-he
  • saxonb (saxonb_8_8)
  • saxonb_9_1
  • xmloscopy

Building darktable the build was hanging, not sure why, so I skipped it in that review.

@paperdigits
Copy link
Contributor

paperdigits commented Aug 18, 2025 via email •
edited by wolfgangwalther
Loading

@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Aug 18, 2025

The only reason I thought to do it the same is that they're more or less the same package, same dependencies, so why have two different ways of doing things?

We're not having two different ways of doing it. We're doing it exactly the same way in both, but simpler - because we moved the symlink thing into saxon. So both packages just need to happily consume that now.

@mBornand
saxon: add -xslt symlink
2b10f11 
Some projects that expect to be built on debian/ubuntu
search for saxon-xslt instead of saxon.
@mBornand
ansel: fix compilation
99e583b 
use saxon instead of libxslt like darktable
remove insecure libsoup_2_4
move libxml2 to buildInputs
@mBornand
ansel: remove special version of libavif
e3a4e20 
ansel works with the current version of libavif
@mBornand
ansel: sort inputs
913cca4
@mBornand
ansel: add missing dependencies
35bb4a9
@mBornand
ansel: remove pcre from buildInputs
a1d176f 
The upstream documentation does not require it
We do not have any error message or warning without it either
@mBornand
ansel: tell the build script we package ansel
fabd624 
We set BINARY_PACKAGE_BUILD=1
This removes the use of -march=native
and also compiles some low-level function
for different vector instruction sets

The upstream repo uses it in ci and packaging instructions.
@mBornand
ansel: add mbornand as maintainer
ecb90c5
@mBornand
Copy link
Contributor Author

mBornand commented Aug 18, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 432089
Commit: ecb90c5bc8096868fb2434c8fc264f43d012ce4a

x86_64-linux

✅ 11 packages built:
  • ansel
  • darktable
  • jing (jing-trang)
  • photoprism
  • saxon
  • saxon-he (saxon_12-he)
  • saxon_11-he
  • saxon_9-he
  • saxonb (saxonb_8_8)
  • saxonb_9_1
  • xmloscopy

@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Aug 18, 2025

Thank you and welcome to Nixpkgs!

@wolfgangwalther wolfgangwalther merged commit 49eb7ac into NixOS:master Aug 18, 2025
24 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rvl rvl Awaiting requested review from rvl

@paperdigits paperdigits Awaiting requested review from paperdigits

@mrVanDalo mrVanDalo Awaiting requested review from mrVanDalo

@freyacodes freyacodes Awaiting requested review from freyacodes

@flosse flosse Awaiting requested review from flosse

@wolfgangwalther wolfgangwalther Awaiting requested review from wolfgangwalther

Assignees

No one assigned

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mBornand @paperdigits @wolfgangwalther