Skip to content

microsoft-edge: 138.0.3351.121 -> 139.0.3405.86#431892

Merged
LeSuisse merged 1 commit intoNixOS:masterfrom
jonhermansen:microsoft-edge-139.0.3405.86
Aug 9, 2025
Merged

microsoft-edge: 138.0.3351.121 -> 139.0.3405.86#431892
LeSuisse merged 1 commit intoNixOS:masterfrom
jonhermansen:microsoft-edge-139.0.3405.86

Conversation

@jonhermansen
Copy link
Member

https://learn.microsoft.com/en-us/deployedge/microsoft-edge-relnote-stable-channel#version-1390340586-august-7-2025

Tested by running BrowserBench Speedometer, watching a YouTube video, and reading a few news articles.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 8, 2025
@nix-owners nix-owners bot requested a review from Daholli August 8, 2025 00:38
@jonhermansen
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 431892

Logs: https://github.com/jonhermansen/nixpkgs-review-gha/actions/runs/16818952938

Download packages from cache:
  • x86_64-linux
    nix-store -r --add-root nixpkgs-pr-431892-x86_64-linux \
      --option binary-caches 'https://cache.nixos.org/ https://jonhermansen.cachix.org' \
      --option trusted-public-keys '
      cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
      jonhermansen.cachix.org-1:SmAT0g8cixKmyT14Ay9aV8bPDKO6kjn35R1jRMWilKo=
      ' \
      /nix/store/n9r7hbhagjsqk0jb4j2zj7vw004zdvrw-microsoft-edge-139.0.3405.86

x86_64-linux

✅ 1 package built:
  • microsoft-edge

x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

@Bricklou
Copy link
Contributor

Bricklou commented Aug 8, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 431892
Commit: ce53065b40dc1b7c8b31875c008808343a3ff897


x86_64-linux

✅ 1 package built:
  • microsoft-edge

Copy link
Contributor

@Bricklou Bricklou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Aug 8, 2025
@Daholli Daholli added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Aug 8, 2025
@Daholli
Copy link
Member

Daholli commented Aug 8, 2025

@jonhermansen btw I think since this always includes upstream chromium fixes, you can just default to adding the security label

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Aug 8, 2025
@jonhermansen
Copy link
Member Author

@jonhermansen btw I think since this always includes upstream chromium fixes, you can just default to adding the security label

You're right @Daholli , I will do so moving forward.

Copy link
Member

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick functional test on Linux x86_64 shows no issue.

@LeSuisse LeSuisse merged commit 240db6a into NixOS:master Aug 9, 2025
34 of 36 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Aug 9, 2025

Cannot read properties of undefined (reading 'startsWith')

@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Aug 9, 2025

Successfully created backport PR for release-25.05:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants