Merged
Conversation
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
austinbutler
reviewed
Aug 7, 2025
nixpkgs-ci
bot
removed
the
9.needs: reviewer
0xda157
force-pushed
the
tuba-0.10.0
branch
2 times, most recently
from
c6ac579 to
ad826c1
Compare
Member
|
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
austinbutler
approved these changes
Aug 7, 2025
Member
austinbutler
left a comment
austinbutler
left a comment
There was a problem hiding this comment.
The new features work well, thanks!
nix-owners
bot
requested review from
Aleksanaa,
chuangzhu,
donovanglover,
getchoo and
michaelgrahamevans
nixpkgs-ci
bot
added
the
12.approvals: 1
Member
|
I guess we have to add clapper-enhancers as well when clapper is enabled, like because
|
Contributor
Author
I added clapper-enhancers but it doesn't seem to want to play youtube videos log |
getchoo
approved these changes
Aug 7, 2025
Member
getchoo
left a comment
getchoo
left a comment
There was a problem hiding this comment.
I assume that's a bug in Clapper, or Youtube just being Youtube nowadays
All other videos I've tested work fine, so I think we're good to go. Thanks for your work!
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 431565
Commit: bf34865e9e19d8577d1ab043521e65a0c2dc8bb9
x86_64-linux
✅ 1 package built:
- tuba
getchoo
added
the
12.approved-by: package-maintainer
nixpkgs-ci
bot
added
12.approvals: 2
Member
|
Yeah with that change, every YouTube video I've tried works within Tuba. |
austinbutler
approved these changes
Aug 7, 2025
Contributor
|
Successfully created backport PR for |
1 task
github-actions
bot
added
the
8.has: port to stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: https://github.com/GeopJr/Tuba/releases/tag/v0.10.0
diff: GeopJr/Tuba@v0.9.2...v0.10.0
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.