Merged
Conversation
yorickvP
approved these changes
Aug 5, 2025
Yarny0
approved these changes
Aug 5, 2025
Contributor
Yarny0
left a comment
There was a problem hiding this comment.
Review per https://github.com/NixOS/nixpkgs/tree/5b09dc45f24cf32316283e62aec81ffee3c3e376/pkgs#package-updates
Reviewed points
Built/tested with asterisk_{18,20,22} (as applicable), with the commit cherry-picked onto current nixos-unstable:
- package name fits guidelines
- package version fits guidelines
- package builds on
x86_64-linux - executables tested on ARCHITECTURE
- any change of upstream are verified (none)
- the motives for any special packaging choices are documented (none)
- all depending packages build (already done by @r-ryantm)
- patches have a comment describing either the upstream URL or a reason why the patch wasn't upstreamed (none)
- patches that are remotely available are fetched rather than vendored (none)
More:
- license still matches upstream
- sent/received some faxes with iaxmodem, using dailplan functions
Busy,Wait,Answer,Playback,Goto,Dial
Comments
According to https://www.asterisk.org/asterisk-news/asterisk-security-releases-22-5-1-21-10-1-20-15-1-18-26-3-certified-20-7-cert7/ , this "security release" fixes GHSA-mrq5-74j5-f5cr and GHSA-v9q8-9j8m-5xwp
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2500 |
Contributor
|
Successfully created backport PR for |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for asterisk is: Software implementation of a telephone private branch exchange (PBX)
meta.homepage for asterisk is: https://www.asterisk.org/
Updates performed
To inspect upstream changes
Impact
Checks done
passthru.tests, if any, passedRebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from the cache:
(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the
trusted-userslist or you can usesudosince root is effectively trusted.Or, build yourself:
Or:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-reviewresultGenerated using
nixpkgs-review.Command:
nixpkgs-reviewx86_64-linux✅ 5 packages built:
Maintainer pings
cc @auntieNeo @DerTim1 @yorickvP for testing.
Tip
As a maintainer, if your package is located under
pkgs/by-name/*, you can comment@NixOS/nixpkgs-merge-bot mergeto automatically merge this update using thenixpkgs-merge-bot.Add a 👍 reaction to pull requests you find important.