Skip to content

nixfmt-tree: use nixfmt in longDescription example#431040

Closed
0xda157 wants to merge 1 commit intoNixOS:masterfrom
0xda157:nixfmt-tree-nixfmt
Closed

nixfmt-tree: use nixfmt in longDescription example#431040
0xda157 wants to merge 1 commit intoNixOS:masterfrom
0xda157:nixfmt-tree-nixfmt

Conversation

@0xda157
Copy link
Contributor

@0xda157 0xda157 commented Aug 4, 2025 •
edited
Loading

seems to have been missed in #425068

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 4, 2025
@0xda157 0xda157 requested a review from a team August 5, 2025 02:40
jfly
jfly approved these changes Aug 5, 2025
View reviewed changes
Copy link
Contributor

@jfly jfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 5, 2025
MattSturgeon
MattSturgeon requested changes Aug 5, 2025
View reviewed changes
Copy link
Contributor

@MattSturgeon MattSturgeon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

However, references in documentation are deliberately not updated yet, to avoid confusion on older revisions and the current release branch.

See #425583

@0xda157 0xda157 closed this Aug 5, 2025
@0xda157 0xda157 deleted the nixfmt-tree-nixfmt branch August 5, 2025 16:45
@infinisil infinisil moved this to Done in Nix formatting Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MattSturgeon MattSturgeon MattSturgeon requested changes

+1 more reviewer

@jfly jfly jfly approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

Nix formatting
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@0xda157 @jfly @MattSturgeon