Skip to content

jsonschema-cli: don't use pname in src and switch to finalAttrs #430674

Merged
Defelo merged 2 commits intoNixOS:masterfrom
kachick:jsonschema-cli-modernize
Aug 5, 2025
Merged

jsonschema-cli: don't use pname in src and switch to finalAttrs #430674
Defelo merged 2 commits intoNixOS:masterfrom
kachick:jsonschema-cli-modernize

Conversation

@kachick
Copy link
Member

@kachick kachick commented Aug 3, 2025 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@kachick

This comment was marked as resolved.

Sign in to view
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 3, 2025
@kachick

This comment was marked as outdated.

Sign in to view
kachick added 2 commits August 4, 2025 00:54
@kachick
jsonschema-cli: don't use pname in src
fb67d03
@kachick
jsonschema-cli: use finalAttrs instead of rec
76c385a 
Removed versionCheckProgram.
This attribute would have required an update in this change,
but I chose to remove it since its functionality is now provided by the default.
See befb2be for detail.
@kachick kachick force-pushed the jsonschema-cli-modernize branch from a62ea40 to 76c385a Compare August 3, 2025 15:54
@kachick
Copy link
Member Author

kachick commented Aug 3, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 430674
Commit: 76c385af8d0acc6a798328cceb9aa6c2ee4807da

x86_64-linux

✅ 1 package built:
  • jsonschema-cli

aarch64-linux

✅ 1 package built:
  • jsonschema-cli

x86_64-darwin

✅ 1 package built:
  • jsonschema-cli

aarch64-darwin

✅ 1 package built:
  • jsonschema-cli

@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 3, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 4, 2025
@Defelo
Copy link
Member

Defelo commented Aug 5, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 430674
Commit: 76c385af8d0acc6a798328cceb9aa6c2ee4807da (subsequent changes)
Merge: 50d61f15c6eb09f8d5ce8cc90f6286da49c87d39

Logs: https://github.com/Defelo/nixpkgs-review-gha/actions/runs/16749286035

Download packages from cache:
  • x86_64-linux 
    nix-store -r --add-root nixpkgs-pr-430674-x86_64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/ll0gz3fglnh7z97p0jqkkr886c4j2pnn-jsonschema-cli-0.32.0
  • aarch64-linux 
    nix-store -r --add-root nixpkgs-pr-430674-aarch64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/mq7xi5l6psrwms0df8ch5fgq523dv0j2-jsonschema-cli-0.32.0
  • aarch64-darwin 
    nix-store -r --add-root nixpkgs-pr-430674-aarch64-darwin \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/gqwirmfjyz9mv439ab5fj2234drjckcl-jsonschema-cli-0.32.0

x86_64-linux

✅ 1 package built:
  • jsonschema-cli

aarch64-linux

✅ 1 package built:
  • jsonschema-cli

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • jsonschema-cli

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • jsonschema-cli

Defelo
Defelo approved these changes Aug 5, 2025
View reviewed changes
Copy link
Member

@Defelo Defelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@Defelo Defelo merged commit 1dd4c02 into NixOS:master Aug 5, 2025
27 of 29 checks passed
@kachick
Copy link
Member Author

kachick commented Aug 5, 2025

Thank you all!

@kachick kachick deleted the jsonschema-cli-modernize branch August 5, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Defelo Defelo Defelo approved these changes

@Sigmanificient Sigmanificient Sigmanificient approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kachick @Defelo @Sigmanificient