w3m: 0.5.3+git20230121 → 0.5.4; add toastal to maintainers

[toastal]

tats/w3m#304

Maintainership & blessing has been handed off from tats to rtka. The code is now actively developed on SourceHut.

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

¹

Footnotes

1. Please consider giving up MS GitHub or offering a non-proprietary, non-US-corporate-controlled mirror for this free software project (like w3m just did!). I wish to delete this Microsoft account in the future, but I need more projects like this to support alternative methods to send patches & contribute. ↩

[anthonyroussel]

The PR should target staging branch because it causes mass rebuilds: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#rebasing-between-branches-ie-from-master-to-staging

[toastal]

I agree with all of these. I was trying to make the minimum changes, but clearly more things need updates. Will look when I return home…

[toastal]

@anthonyroussel I believe all is addressed… comments & staging-next

[toastal]

Looks like the formatter failed on the an extra newline

[nix-owners]

The PR's base branch is set to staging, but 190 commits from the master branch are included. Make sure you know the right base branch for your changes, then:

• If the changes should go to the master branch, change the base branch to master
• If the changes should go to the staging branch, rebase your PR onto the merge base with the staging branch:

  # git rebase --onto $(git merge-base upstream/staging HEAD) $(git merge-base upstream/master HEAD)
  git rebase --onto fa154dda31ab1a92efb0d1b79bacc6c6174c5333 20089a898226b2c73114804f6833364f073605e4
  git push --force-with-lease

[toastal]

Oh… good bot. Forgot where I needed to rebase from. Switched to using finalAttrs.

[philiptaron]

Can you assess whether the patches are still needed?

Anyone who is able, please run nixpkgs-review pr 430585 -p w3m --no-shell --post-result - I'd love to merge this and that would help.

[philiptaron]

TIL that w3m is part of every NixOS system because of this:

https://discourse.nixos.org/t/nixos-documentation-nixos-help-use-w3m-1-by-default/3124

[toastal]

nixpkgs-review pr 430585 -p w3m --no-shell is building a lot of packages (as pointed out). GNU coreutils 9.7 had a failure after an hour of compiling the universe across 2 machines. Rebasing, as maybe that is fixed.

[toastal]

Crap, rebased off the default branch again.

[nix-owners]

The PR's base branch is set to staging, but 29 commits from the master branch are included. Make sure you know the right base branch for your changes, then:

• If the changes should go to the master branch, change the base branch to master
• If the changes should go to the staging branch, rebase your PR onto the merge base with the staging branch:

  # git rebase --onto $(git merge-base upstream/staging HEAD) $(git merge-base upstream/master HEAD)
  git rebase --onto ee11c0fef4ce23fa64299c30243eb0f4e1db4845 c202cddaf0aa39c9200af733cc088433b5c3406f
  git push --force-with-lease

[toastal]

As for the patches, they still apply as the code in those spots haven’t changed. The fetched one uncomments values in struct cmdtable schemetable[], & the one in Nixpkgs does something with EDG for randomness? I can’t tell you want these are for off the top of my head.

[toastal]

TIL that w3m is part of every NixOS system because of this:

I have used this before in specifically the NixOS ISO to set up a new device.

[philiptaron]

I'm running the nixpkgs-review.

[philiptaron]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 430585 --package w3m
Commit: 76d0ab5d74796392aabd37454c4dfee142f99a4e

---

x86_64-linux

✅ 1 package built:

• w3m