Skip to content

conman: init at 0.3.1#430136

Merged
SuperSandro2000 merged 3 commits intoNixOS:masterfrom
frantathefranta:add-conman
Aug 15, 2025
Merged

conman: init at 0.3.1#430136
SuperSandro2000 merged 3 commits intoNixOS:masterfrom
frantathefranta:add-conman

Conversation

@frantathefranta
Copy link
Contributor

@frantathefranta frantathefranta commented Aug 1, 2025

Hi, I'm adding the conman package as I use it fairly often on Debian and Red Hat systems. ConMan is a serial console management program designed to support a large number of console devices and simultaneous users. Along with the package, I'm adding a service module to ease the deployment.

I've built this on my own machine and using it day-to-day.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 12.first-time contribution This PR is the author's first one; please be gentle! 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Aug 1, 2025
@frantathefranta frantathefranta changed the title Add conman Add conman pkg and service Aug 1, 2025
Copy link
Contributor

@acid-bong acid-bong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Evening and welcome to Nixpkgs. Here's a couple notes to consider. Another general tip:

  • read the docs (see the end of the checklist) on how to organize your code in commits; also check out other (preferably approved and merged PRs)
  • speaking of commits, you should have only three: new maintainer > new package > new module -- squash your edits to these three

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Aug 1, 2025
@frantathefranta frantathefranta force-pushed the add-conman branch 2 times, most recently from fc3cfb1 to 789a5b9 Compare August 1, 2025 17:04
@frantathefranta frantathefranta force-pushed the add-conman branch 2 times, most recently from b34f446 to 79365f3 Compare August 7, 2025 18:18
@frantathefranta
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 430136
Commit: 79365f31ef1cd6150a17a599cdaf4d648040b1f8


x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 1 package built:
  • conman

@acid-bong
Copy link
Contributor

And prolly forgot to mention explicitly: the PR should adhere to the same conventions as commits. Rename this one please

@frantathefranta frantathefranta changed the title Add conman pkg and service conman: init at 0.3.1 Aug 7, 2025
@frantathefranta
Copy link
Contributor Author

And prolly forgot to mention explicitly: the PR should adhere to the same conventions as commits. Rename this one please

Renamed now

@frantathefranta
Copy link
Contributor Author

@acid-bong is there anything else you'd like to see changed/fixed?

Copy link
Contributor

@acid-bong acid-bong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, GG

@acid-bong
Copy link
Contributor

Ah, forgot one thing: new modules have to be mentioned in release notes (25.11 for now). Squash that change to the init module commit (given it's last, git commit --amend --no-edit would fit the best), so that the docs are populated simultaneously with the module init.

@acid-bong
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 430136

Logs: https://github.com/acid-bong/nixpkgs-review-gha/actions/runs/16914308963


x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 1 package built:
  • conman

aarch64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 1 package built:
  • conman

x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 12, 2025
Adding this package along with a service. https://github.com/dun/conman/releases/tag/conman-0.3.1

Changes to conman package as per review

Enabled parallel building for the conman package
@nixpkgs-ci nixpkgs-ci bot added the 8.has: changelog This PR adds or changes release notes label Aug 12, 2025
@nixpkgs-ci nixpkgs-ci bot added the 8.has: documentation This PR adds or changes documentation label Aug 12, 2025
@acid-bong
Copy link
Contributor

Add your module in https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/module-list.nix, at the moment it doesn't get sourced and docs fail to build

Adding a service for the conman package

Changes to conman service as per review
@frantathefranta
Copy link
Contributor Author

Add your module in https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/module-list.nix, at the moment it doesn't get sourced and docs fail to build

Thanks for the head's-up, I was wondering what I was missing.

Copy link
Contributor

@acid-bong acid-bong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phew, now we're good. Final approval this time 😅 Welcome to Nixpkgs and good luck nixing

@frantathefranta
Copy link
Contributor Author

@acid-bong Is there anything missing for this to get merged? I'm unsure if I need to do anything haha

@acid-bong
Copy link
Contributor

only attention of merging folks. feel free to post in #review-requests:nixos.org Matrix room

@SuperSandro2000 SuperSandro2000 merged commit 316781d into NixOS:master Aug 15, 2025
26 of 28 checks passed
@frantathefranta frantathefranta deleted the add-conman branch August 15, 2025 18:31
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Aug 15, 2025

Backport failed for release-25.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.05
git worktree add -d .worktree/backport-430136-to-release-25.05 origin/release-25.05
cd .worktree/backport-430136-to-release-25.05
git switch --create backport-430136-to-release-25.05
git cherry-pick -x 5d75012b621292c8215f70f68b1640c5f07eb790 725442d69ca3d0f7c902626665fca83c01602ce3 8b9723146053ce5b4b067567f679e08098cb1512

@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Aug 15, 2025

Backport failed for release-25.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.05
git worktree add -d .worktree/backport-430136-to-release-25.05 origin/release-25.05
cd .worktree/backport-430136-to-release-25.05
git switch --create backport-430136-to-release-25.05
git cherry-pick -x 5d75012b621292c8215f70f68b1640c5f07eb790 725442d69ca3d0f7c902626665fca83c01602ce3 8b9723146053ce5b4b067567f679e08098cb1512

@mdaniels5757 mdaniels5757 added 8.has: port to stable This PR already has a backport to the stable release. and removed backport release-25.05 labels Aug 15, 2025
@h7x4 h7x4 added the 8.has: module (new) This PR adds a module in `nixos/` label Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants