conman: init at 0.3.1#430136
Conversation
2350b52 to
cdd2193
Compare
There was a problem hiding this comment.
Evening and welcome to Nixpkgs. Here's a couple notes to consider. Another general tip:
- read the docs (see the end of the checklist) on how to organize your code in commits; also check out other (preferably approved and merged PRs)
- speaking of commits, you should have only three: new maintainer > new package > new module -- squash your edits to these three
fc3cfb1 to
789a5b9
Compare
b34f446 to
79365f3
Compare
|
|
And prolly forgot to mention explicitly: the PR should adhere to the same conventions as commits. Rename this one please |
Renamed now |
|
@acid-bong is there anything else you'd like to see changed/fixed? |
|
Ah, forgot one thing: new modules have to be mentioned in release notes (25.11 for now). Squash that change to the |
|
Adding this package along with a service. https://github.com/dun/conman/releases/tag/conman-0.3.1 Changes to conman package as per review Enabled parallel building for the conman package
79365f3 to
c27e711
Compare
|
Add your module in https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/module-list.nix, at the moment it doesn't get sourced and docs fail to build |
Adding a service for the conman package Changes to conman service as per review
c27e711 to
8b97231
Compare
Thanks for the head's-up, I was wondering what I was missing. |
acid-bong
left a comment
There was a problem hiding this comment.
Phew, now we're good. Final approval this time 😅 Welcome to Nixpkgs and good luck nixing
|
@acid-bong Is there anything missing for this to get merged? I'm unsure if I need to do anything haha |
|
only attention of merging folks. feel free to post in |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.05
git worktree add -d .worktree/backport-430136-to-release-25.05 origin/release-25.05
cd .worktree/backport-430136-to-release-25.05
git switch --create backport-430136-to-release-25.05
git cherry-pick -x 5d75012b621292c8215f70f68b1640c5f07eb790 725442d69ca3d0f7c902626665fca83c01602ce3 8b9723146053ce5b4b067567f679e08098cb1512 |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.05
git worktree add -d .worktree/backport-430136-to-release-25.05 origin/release-25.05
cd .worktree/backport-430136-to-release-25.05
git switch --create backport-430136-to-release-25.05
git cherry-pick -x 5d75012b621292c8215f70f68b1640c5f07eb790 725442d69ca3d0f7c902626665fca83c01602ce3 8b9723146053ce5b4b067567f679e08098cb1512 |
Hi, I'm adding the
conmanpackage as I use it fairly often on Debian and Red Hat systems. ConMan is a serial console management program designed to support a large number of console devices and simultaneous users. Along with the package, I'm adding aservicemodule to ease the deployment.I've built this on my own machine and using it day-to-day.
Things done
x86_64-darwinaarch64-darwinpassthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.