Skip to content

[Backport release-25.05] nixos/qbittorrent: init#429630

Merged
andresilva merged 3 commits intoNixOS:release-25.05from
undefined-landmark:backport-287923-to-release-25.05
Aug 1, 2025
Merged

[Backport release-25.05] nixos/qbittorrent: init#429630
andresilva merged 3 commits intoNixOS:release-25.05from
undefined-landmark:backport-287923-to-release-25.05

Conversation

@undefined-landmark
Copy link
Contributor

@undefined-landmark undefined-landmark commented Jul 30, 2025

A service module for qbittorrent has recently been merged: #287923. Shortly thereafter I was added as a maintainer: #427481.

An automated backport was not possible due to a merge conflict in the release notes. In this PR the relevant commits were cherry picked, i.e. the module and my maintainer status, and the conflict in the release notes was fixed.

As this is a new module I assume this is acceptable for a backport, based on CONTRIBUTING.md. It is my first backport so please let me know if I miss anything.

Thanks!

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

nuko and others added 3 commits July 30, 2025 17:04
nixos/qbittorrent: add default serverConfig & fix test

Migrate to runTest

Replace lib.optional with lib.optionals

nixos/qbittorrent: update release notes to 2511

(cherry picked from commit 84d174e)
(cherry picked from commit 6caef45)
As discussed in PR NixOS#287923. The author agreed to add me as a maintainer
to the module after merging.

(cherry picked from commit 380cd59)
@undefined-landmark
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 429630 --package nixosTests.qbittorrent
Commit: 13df1220cc694b8f10e104f065967ac896b1f614


x86_64-linux

✅ 1 test built:
  • nixosTests.qbittorrent

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 4.workflow: backport This targets a stable branch 8.has: documentation This PR adds or changes documentation labels Jul 30, 2025
@eclairevoyant eclairevoyant mentioned this pull request Jul 31, 2025
19 tasks
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 31, 2025
@andresilva andresilva merged commit 6405831 into NixOS:release-25.05 Aug 1, 2025
37 of 39 checks passed
@undefined-landmark undefined-landmark deleted the backport-287923-to-release-25.05 branch August 1, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.workflow: backport This targets a stable branch 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants