Skip to content

postgresql18Packages: fix build or mark as broken#429371

Merged
wolfgangwalther merged 2 commits intoNixOS:masterfrom
diogotcorreia:vectorchord-broken-pg18
Aug 9, 2025
Merged

postgresql18Packages: fix build or mark as broken#429371
wolfgangwalther merged 2 commits intoNixOS:masterfrom
diogotcorreia:vectorchord-broken-pg18

Conversation

@diogotcorreia
Copy link
Member

@diogotcorreia diogotcorreia commented Jul 29, 2025 •
edited
Loading

The extension doesn't build on postgres 18 yet: https://hydra.nixos.org/build/303621630

From what I can see in upstream's main branch, the next release will support it.

Upgraded/fixed:

Marked remaining build failures as broken.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@diogotcorreia diogotcorreia force-pushed the vectorchord-broken-pg18 branch from c09bea4 to 893c248 Compare July 29, 2025 14:36
@diogotcorreia diogotcorreia changed the title postgresPackages.vectorchord: mark as broken on pg18 postgresqlPackages.vectorchord: mark as broken on pg18 Jul 29, 2025
@nix-owners nix-owners bot requested review from Ma27 and thoughtpolice July 29, 2025 14:38
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 29, 2025
@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Aug 3, 2025

We currently have not marked any extension as broken on PG 18, except when they were broken on PG 17 already. I'd say we can either keep all of them without the broken marker to see where they end up after PG 18 progresses through RCs and the final release - or we mark all of them as broken now.

I'm in favor of not marking them broken right now.

@diogotcorreia
Copy link
Member Author

diogotcorreia commented Aug 3, 2025

My argument for marking this one as broken is that it explicitly does not support pg18 unless it is updated in the future. Doesn't matter if pg18 is upgraded to a stable version.

Just thought it would help with reducing the load on hydra, but feel free to close.

@Ma27
Copy link
Member

Ma27 commented Aug 7, 2025

My argument for marking this one as broken is that it explicitly does not support pg18 unless it is updated in the future. Doesn't matter if pg18 is upgraded to a stable version.

I think that's fair, actually.
Wdyt @wolfgangwalther?

@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Aug 7, 2025

I think the same reasoning applies to all pg extensions that are currently not supporting PG 18, yet. So I still think we should do this for all of them - or don't bother. A single build that exits after a few seconds because it doesn't support this version also doesn't change much for hydra, while 20-ish builds.. make a bit more of a difference.

@diogotcorreia
Copy link
Member Author

diogotcorreia commented Aug 7, 2025

I'll update this PR to include the other extensions as well then

@diogotcorreia
postgresqlPackages.pg_hll: fix build on pg18
794d422 
PostgreSQL 18 adds the -Wmissing-variable-declarations flag by default,
which makes this build fail. Ignoring this warning allows the build to
succeed.
@diogotcorreia diogotcorreia force-pushed the vectorchord-broken-pg18 branch from 893c248 to 4cd7afc Compare August 7, 2025 21:53
@diogotcorreia diogotcorreia changed the title postgresqlPackages.vectorchord: mark as broken on pg18 postgresql18Packages: upgrade or mark as broken Aug 7, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 7, 2025
@diogotcorreia diogotcorreia changed the title postgresql18Packages: upgrade or mark as broken postgresql18Packages: upgrade, fix build, or mark as broken Aug 7, 2025
diogotcorreia
diogotcorreia commented Aug 7, 2025
View reviewed changes
Copy link
Member Author

@diogotcorreia diogotcorreia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 429371
Commit: 4cd7afc36d5bd615a589a6386f69c53ad52fc98e

x86_64-linux

✅ 12 packages built:
  • postgresql13Packages.pg_hll
  • postgresql13Packages.pg_squeeze
  • postgresql14Packages.pg_hll
  • postgresql14Packages.pg_squeeze
  • postgresql15Packages.pg_hll
  • postgresql15Packages.pg_squeeze
  • postgresql16Packages.pg_hll
  • postgresql16Packages.pg_squeeze
  • postgresql17Packages.pg_hll
  • postgresql17Packages.pg_squeeze
  • postgresql18Packages.pg_hll
  • postgresql18Packages.pg_squeeze

wolfgangwalther
wolfgangwalther reviewed Aug 8, 2025
View reviewed changes
@diogotcorreia
postgresql18Packages: mark remaining extensions as broken
108733a 
Those extensions don't support building with PostgreSQL 18, yet.

To make sure the broken status is updated on the next upgrade, they all
have version checks in the form of an evaluation warning, so that there
has be explicit action regarding its PG18 compatibility.
@diogotcorreia diogotcorreia force-pushed the vectorchord-broken-pg18 branch from 4cd7afc to 108733a Compare August 8, 2025 23:08
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. and removed 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Aug 8, 2025
@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Aug 9, 2025

Thank you!

@wolfgangwalther wolfgangwalther changed the title postgresql18Packages: upgrade, fix build, or mark as broken postgresql18Packages: fix build or mark as broken Aug 9, 2025
@wolfgangwalther wolfgangwalther merged commit 7f73aa5 into NixOS:master Aug 9, 2025
29 of 31 checks passed
@diogotcorreia diogotcorreia deleted the vectorchord-broken-pg18 branch August 9, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ma27 Ma27 Awaiting requested review from Ma27

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@wolfgangwalther wolfgangwalther Awaiting requested review from wolfgangwalther

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@diogotcorreia @wolfgangwalther @Ma27