Skip to content

systemd: Re-enable BPF support on powerpc64le#429053

Merged
flokli merged 1 commit intoNixOS:masterfrom
OPNA2608:add/systemd-ppc64le-bpf
Jul 31, 2025
Merged

systemd: Re-enable BPF support on powerpc64le#429053
flokli merged 1 commit intoNixOS:masterfrom
OPNA2608:add/systemd-ppc64le-bpf

Conversation

@OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Jul 28, 2025

Missing header was due to missing defines. Our Meson cross setup didn't set the correct cpu_family value for little-endian POWER, so upstream's Meson code can't identify the platform correctly and doesn't pass some necessary flags to the compiler.

With #428810 merged, this builds again.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • powerpc64le-linux (cross)
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. labels Jul 28, 2025
@OPNA2608 OPNA2608 force-pushed the add/systemd-ppc64le-bpf branch from 0635b5a to 4d286b5 Compare July 31, 2025 09:53
@OPNA2608 OPNA2608 marked this pull request as ready for review July 31, 2025 09:54
@flokli
Copy link
Member

flokli commented Jul 31, 2025

I don't see a change in the derivation hash (nix-instantiate -A systemd --argstr system powerpc64-unknown-linux-gnuabielfv1, as well as nix-instantiate -A pkgsCross.ppc64-elfv1.systemd --argstr system aarch64-linux - that is, d5b6a55 with the following cherry-picked on top:

  • cc-wrapper: Workaround gnuabielfv{1,2} support deficiency on Clang
  • ncurses: Add patch to recognise linux-gnuabielfv{1,2}
  • kexec-tools: Only force ELFv2 on ppc64 when the platform settings aggree
  • this PR (vs without this PR)

How am I holding this wrong?

@OPNA2608
Copy link
Contributor Author

It's for powerpc64le-linux. So either -A systemd --argstr crossSystem powerpc64le-linux or -A pkgsCross.powernv.systemd.

(This one should work without applying any other commits, unless something seriously broke about ppc64le cross since I opened this)

@flokli
Copy link
Member

flokli commented Jul 31, 2025

Yes, you're right, and the build succeeds.

@flokli flokli merged commit 35143da into NixOS:master Jul 31, 2025
27 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants