{python3Packages.textual,tree-sitter.grammars}: unbreak#428417
Merged
happysalada merged 7 commits intoNixOS:masterfrom Jul 26, 2025
Merged
{python3Packages.textual,tree-sitter.grammars}: unbreak#428417happysalada merged 7 commits intoNixOS:masterfrom
happysalada merged 7 commits intoNixOS:masterfrom
Conversation
3 tasks
dtomvan
force-pushed
the
textual-unbreak+grammars
branch
from
d169d95 to
4a27842
Compare
nixpkgs-ci
bot
added
10.rebuild-linux: 101-500
dtomvan
force-pushed
the
textual-unbreak+grammars
branch
from
4a27842 to
f79bce7
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
nixpkgs-ci
bot
added
the
2.status: merge conflict
This comment was marked as off-topic.
This comment was marked as off-topic.
…6-02" This reverts commit 2e433f1.
This reverts commit 56cca54.
This commit prevents the update script from touching the files listed under `pinnedGrammars`. This way breakages cannot accidentally be caused again (re: NixOS#414233 breaking the heck out of staging-next et al)
this partially reverts 2c0bcc5
This allows it to be updated according to the release cadence of the entire ecosystem, not as github tags are pushed. See: NixOS#425177
dtomvan
force-pushed
the
textual-unbreak+grammars
branch
from
f79bce7 to
21c5e94
Compare
nixpkgs-ci
bot
removed
the
2.status: merge conflict
dtomvan
changed the title
13 tasks
This reverts commit c25bc14.
Contributor
Author
|
Contributor
|
nixpkgs-ci
bot
added
12.approvals: 1
13 tasks
gepbird
reviewed
Oct 9, 2025
Comment on lines
-23
to
+24
| src = fetchFromGitHub { | ||
| owner = "tree-sitter"; | ||
| repo = "py-tree-sitter"; | ||
| rev = "9c78f3b8d10f81b97fbb2181c9333323d6375480"; | ||
| hash = "sha256-jPqTraGrYFXBlci4Zaleyp/NTQhvuI39tYWRckjnV2E="; | ||
| fetchSubmodules = true; | ||
| src = fetchPypi { | ||
| inherit pname version; | ||
| hash = "sha256-q9la9lyi9Pfso1Y0M5HtZp52Tzd0i1NSlG8A9/x45zQ="; |
Contributor
There was a problem hiding this comment.
Previously the package was outdated on PyPI and we were using a newer version from a Git tag, which caused some issues.
Upstream fixed their CI since, which publishes the package to PyPI.
Now both Pypi and the Git tag have the latest version.
Should we revert this? By reverting, we could run tests again, but risk the same issue potentially happening in the future.
Contributor
There was a problem hiding this comment.
Running tests again would be nice.
We can always go back to pypi if this is a problem again.
Contributor
There was a problem hiding this comment.
doronbehar
added a commit
to doronbehar/nixpkgs
that referenced
this pull request
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge before #428416
Fixes #425335 (comment)
Built
discordandotermwith it.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.