Skip to content

music-assistant: 2.5.2 -> 2.5.5#428158

Merged
mweinelt merged 3 commits intoNixOS:masterfrom
mweinelt:music-assistant-2.5.5
Jul 24, 2025
Merged

music-assistant: 2.5.2 -> 2.5.5#428158
mweinelt merged 3 commits intoNixOS:masterfrom
mweinelt:music-assistant-2.5.5

Conversation

@mweinelt
Copy link
Copy Markdown
Member

@mweinelt mweinelt commented Jul 24, 2025 

https://github.com/music-assistant/server/releases/tag/2.5.3
https://github.com/music-assistant/server/releases/tag/2.5.4
https://github.com/music-assistant/server/releases/tag/2.5.5
https://github.com/khers/py-opensonic/blob/refs/tags/v7.0.2/CHANGELOG.md
https://github.com/avian2/unidecode/blob/unidecode-1.4.0/ChangeLog

Fixes: #428130

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 6.topic: python Python is a high-level, general-purpose programming language. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jul 24, 2025
@mweinelt mweinelt requested a review from matteo-pacini July 24, 2025 21:29
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 24, 2025
matteo-pacini
matteo-pacini approved these changes Jul 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@matteo-pacini matteo-pacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick update @mweinelt

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 428158 --package music-assistant --package nixosTests.music-assistant
Commit: e8809a8f5f64d1482f6f35e5237f25760952f980

x86_64-linux

✅ 1 test built:
  • nixosTests.music-assistant
✅ 2 packages built:
  • music-assistant
  • music-assistant.dist (music-assistant.dist.dist)

@matteo-pacini matteo-pacini added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 24, 2025
@mweinelt mweinelt merged commit f198732 into NixOS:master Jul 24, 2025
30 of 33 checks passed
@mweinelt mweinelt deleted the music-assistant-2.5.5 branch July 24, 2025 22:41
wolfgangwalther
wolfgangwalther reviewed Aug 14, 2025
View reviewed changes
pkgs/by-name/mu/music-assistant/update-providers.py
@@ -1,5 +1,5 @@
#!/usr/bin/env nix-shell
#!nix-shell -I nixpkgs=./. -i python3 -p "music-assistant.python.withPackages (ps: music-assistant.dependencies ++ (with ps; [ jinja2 packaging ]))" -p pyright ruff isort
#!nix-shell -I nixpkgs=./. -i python3 -p "music-assistant.python.withPackages (ps: music-assistant.dependencies ++ (with ps; [ jinja2 packaging ]))" -p nixfmt pyright ruff isort
Copy link
Copy Markdown
Contributor

@wolfgangwalther wolfgangwalther Aug 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixfmt was removed on purpose from update scripts' shebangs in b68cc63. This is expected to be available via nixpkgs' nix-shell environment / treefmt configuration instead.

Removed again in #433588.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther left review comments

@matteo-pacini matteo-pacini matteo-pacini approved these changes

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Request: music-assistant 2.5.2 → 2.5.5

3 participants

@mweinelt @matteo-pacini @wolfgangwalther