various: Don't depend on libsoup2#428043
Merged
bobby285271 merged 5 commits intoNixOS:masterfrom Jul 25, 2025
Merged
Conversation
This already depends on libedataserver-1.2 which requires libsoup3.
webservices completely removed on upstream in next release: https://gitlab.gnome.org/GNOME/gthumb/-/commit/6738d43fe1b48745fde80a9ca5c80f8e0f12f7e9
bobby285271
force-pushed
the
upd/libsoup2
branch
from
c7a5808 to
fe05b67
Compare
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
nix-owners
bot
requested review from
dasj19,
hedning,
jtojnar,
mimame,
mkg20001 and
romildo
Contributor
|
jtojnar
approved these changes
Jul 24, 2025
Member
jtojnar
left a comment
jtojnar
left a comment
There was a problem hiding this comment.
Changes look good, did not test.
nixpkgs-ci
bot
added
12.approvals: 1
Member
|
Tested |
Member
|
LordGrimmauld
approved these changes
Jul 25, 2025
Contributor
LordGrimmauld
left a comment
LordGrimmauld
left a comment
There was a problem hiding this comment.
Diff looks fine, the referenced issues/PRs all exist and are related. I did not run these things, but seeing as they build without libsoup now, this is probably always better than what we had before.
nixpkgs-ci
bot
added
12.approvals: 2
13 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc #427813
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.